Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2483463002: [Offline Pages] Feature flag to allow concurrent background loading on svelte (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | components/offline_pages/background/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2081 matching lines...) Expand 10 before | Expand all | Expand 10 after
2092 #if BUILDFLAG(ENABLE_PRINT_PREVIEW) 2092 #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
2093 {"print-scaling", IDS_FLAGS_PRINT_SCALING_NAME, 2093 {"print-scaling", IDS_FLAGS_PRINT_SCALING_NAME,
2094 IDS_FLAGS_PRINT_SCALING_DESCRIPTION, kOsDesktop, 2094 IDS_FLAGS_PRINT_SCALING_DESCRIPTION, kOsDesktop,
2095 FEATURE_VALUE_TYPE(features::kPrintScaling)}, 2095 FEATURE_VALUE_TYPE(features::kPrintScaling)},
2096 #endif // !defined(OS_ANDROID) 2096 #endif // !defined(OS_ANDROID)
2097 #if defined(OS_ANDROID) 2097 #if defined(OS_ANDROID)
2098 {"enable-consistent-omnibox-geolocation", 2098 {"enable-consistent-omnibox-geolocation",
2099 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_NAME, 2099 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_NAME,
2100 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_DESCRIPTION, kOsAndroid, 2100 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_DESCRIPTION, kOsAndroid,
2101 FEATURE_VALUE_TYPE(features::kConsistentOmniboxGeolocation)}, 2101 FEATURE_VALUE_TYPE(features::kConsistentOmniboxGeolocation)},
2102 {"concurrent-background-loading-on-svelte",
2103 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_NAME,
2104 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_DESCRIPTION, kOsAndroid,
2105 FEATURE_VALUE_TYPE(
2106 offline_pages::kOfflinePagesSvelteConcurrentLoadingFeature)},
2102 #endif 2107 #endif
2103 // NOTE: Adding new command-line switches requires adding corresponding 2108 // NOTE: Adding new command-line switches requires adding corresponding
2104 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2109 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2105 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2110 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2106 }; 2111 };
2107 2112
2108 class FlagsStateSingleton { 2113 class FlagsStateSingleton {
2109 public: 2114 public:
2110 FlagsStateSingleton() 2115 FlagsStateSingleton()
2111 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2116 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
2301 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2306 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2302 2307
2303 const FeatureEntry* GetFeatureEntries(size_t* count) { 2308 const FeatureEntry* GetFeatureEntries(size_t* count) {
2304 *count = arraysize(kFeatureEntries); 2309 *count = arraysize(kFeatureEntries);
2305 return kFeatureEntries; 2310 return kFeatureEntries;
2306 } 2311 }
2307 2312
2308 } // namespace testing 2313 } // namespace testing
2309 2314
2310 } // namespace about_flags 2315 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | components/offline_pages/background/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698