Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 248343003: Fixing a race condition in landmines.py (Closed)

Created:
6 years, 8 months ago by smut
Modified:
6 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixing a race condition in landmines.py Landmines.py had some logic where it would first check if a directory existed before creating it, but this was sometimes causing an exception wherein the file was reported as existing during the os.mkdirs call, even though it was not reported as existing during the os.path.exists call. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265532

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/landmines.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
iannucci
lgtm
6 years, 8 months ago (2014-04-22 23:22:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/smut@google.com/248343003/20001
6 years, 8 months ago (2014-04-22 23:23:09 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 04:19:26 UTC) #3
Message was sent while issue was closed.
Change committed as 265532

Powered by Google App Engine
This is Rietveld 408576698