Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 248343002: Convert chromeos::EventRewriter to a ui::EventRewriter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x354034-kder
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index 7f0d1ce491177737cb052ee5f2b6af220e8716f2..74a164d8ffdcb755630ed85d5005bf56fab9d032 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -704,12 +704,12 @@ void ChromeBrowserMainPartsChromeos::PreBrowserStart() {
// Start the CrOS input device UMA watcher
DeviceUMA::GetInstance();
-
- event_rewriter_.reset(new EventRewriter());
#endif
keyboard_event_rewriters_.reset(new EventRewriterController());
keyboard_event_rewriters_->AddEventRewriter(
scoped_ptr<ui::EventRewriter>(new KeyboardDrivenEventRewriter()).Pass());
+ keyboard_event_rewriters_->AddEventRewriter(
+ scoped_ptr<ui::EventRewriter>(new EventRewriter()).Pass());
Daniel Erat 2014/04/22 23:58:36 don't quote me on it, but i think that you don't n
kpschoedel 2014/04/23 15:46:22 Done.
// -- This used to be in ChromeBrowserMainParts::PreMainMessageLoopRun()
// -- immediately after ChildProcess::WaitForDebugger().
@@ -781,8 +781,6 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() {
keyboard_event_rewriters_->Shutdown();
#if defined(USE_X11)
- event_rewriter_.reset();
-
// The XInput2 event listener needs to be shut down earlier than when
// Singletons are finally destroyed in AtExitManager.
XInputHierarchyChangedEventListener::GetInstance()->Stop();

Powered by Google App Engine
This is Rietveld 408576698