Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
248343002:
Convert chromeos::EventRewriter to a ui::EventRewriter (Closed)
|
Created:
6 years, 8 months ago by kpschoedel Modified:
6 years, 7 months ago CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@x354034-kder Visibility:
Public. |
DescriptionConvert chromeos::EventRewriter to a ui::EventRewriter
StickyKeys (crbug.com/354035) and device IDs (crbug.com/360377) remain to be converted.
BUG=354034
TEST=unit_test
R=sadrul@chromium.org,derat@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267578
Patch Set 1 #
Total comments: 28
Patch Set 2 : Addressed review comments #
Total comments: 1
Patch Set 3 : Sync with https://codereview.chromium.org/240173007/ #Patch Set 4 : Restore XI2 monitoring for device IDs. #
Total comments: 14
Patch Set 5 : Address comments and format #Patch Set 6 : Sync with master and 240173007 #Patch Set 7 : resync to master #Patch Set 8 : Restore XEvent send_event test #Patch Set 9 : Fix comments to please lint #Patch Set 10 : Sync with master for flawless victory #Patch Set 11 : Bug fix: non-native event under X11 #
Messages
Total messages: 59 (0 generated)
Incorporates feedback from https://codereview.chromium.org/237363005/ (closed) Assumes https://codereview.chromium.org/240173007/ Convert KeyboardDrivenEventRewriter to a ui::EventRewriter.
this mostly looks fine to me; i just have some nits. didn't review the tests yet. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/chro... File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right): https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/chro... chrome/browser/chromeos/chrome_browser_main_chromeos.cc:712: scoped_ptr<ui::EventRewriter>(new EventRewriter()).Pass()); don't quote me on it, but i think that you don't need the .Pass() here (since the compiler knows that the scoped_ptr is being passed). the KeyboardDrivenEventRewriter could be updated too, then. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... File chrome/browser/chromeos/events/event_rewriter.cc (right): https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:12: #undef RootWindow can you move these #undefs into the #if block? https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:36: namespace { put this anonymous namespace inside of the chromeos namespace so you don't need a bunch of chromeos:: qualifiers within it https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:40: // A key code and a flag we should use when a key is remapped to |remap_to|. nit: update this comment to describe what |pref_name| is used for (presumably, whether the remapping should be done or not) https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:58: 0 }, s/0/NULL/ https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:64: 0 }, s/0/NULL/ https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:146: if ((event.type() == ui::ET_KEY_PRESSED) || nit: switch statement instead of if/else here https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:169: if (event.IsMouseEvent()) add curly brackets since the statement is more than one line https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:172: else here too https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:240: default: huh, i didn't know that putting default first like this even works. please move it below all the cases. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:256: if (!remapped_key && kModifierRemappings[i].pref_name) add curly brackets https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:582: // By default the top row (F1-F12) keys are special keys for back, forward, s/special/system/g in this section of the code, maybe? (at least, i think that that's the terminology that's been used elsewhere) https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... File chrome/browser/chromeos/events/event_rewriter.h (right): https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.h:103: int GetRemappedModifierMasks(const PrefService& pref_service, nit: add a comment describing this method https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.h:114: MutableKeyState* remapped); nit: maybe rename this to |remapped_state| so it's more distinct from |remappings|
https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/chro... File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right): https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/chro... chrome/browser/chromeos/chrome_browser_main_chromeos.cc:712: scoped_ptr<ui::EventRewriter>(new EventRewriter()).Pass()); On 2014/04/22 23:58:36, Daniel Erat wrote: > don't quote me on it, but i think that you don't need the .Pass() here (since > the compiler knows that the scoped_ptr is being passed). the > KeyboardDrivenEventRewriter could be updated too, then. Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... File chrome/browser/chromeos/events/event_rewriter.cc (right): https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:12: #undef RootWindow On 2014/04/22 23:58:36, Daniel Erat wrote: > can you move these #undefs into the #if block? Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:36: namespace { On 2014/04/22 23:58:36, Daniel Erat wrote: > put this anonymous namespace inside of the chromeos namespace so you don't need > a bunch of chromeos:: qualifiers within it Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:40: // A key code and a flag we should use when a key is remapped to |remap_to|. On 2014/04/22 23:58:36, Daniel Erat wrote: > nit: update this comment to describe what |pref_name| is used for (presumably, > whether the remapping should be done or not) Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:58: 0 }, On 2014/04/22 23:58:36, Daniel Erat wrote: > s/0/NULL/ Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:64: 0 }, On 2014/04/22 23:58:36, Daniel Erat wrote: > s/0/NULL/ Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:146: if ((event.type() == ui::ET_KEY_PRESSED) || On 2014/04/22 23:58:36, Daniel Erat wrote: > nit: switch statement instead of if/else here Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:169: if (event.IsMouseEvent()) On 2014/04/22 23:58:36, Daniel Erat wrote: > add curly brackets since the statement is more than one line Done. Sorry, I mistook the ‘one line’ rule as ‘one statement’. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:172: else On 2014/04/22 23:58:36, Daniel Erat wrote: > here too Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:240: default: On 2014/04/22 23:58:36, Daniel Erat wrote: > huh, i didn't know that putting default first like this even works. please move > it below all the cases. Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:256: if (!remapped_key && kModifierRemappings[i].pref_name) On 2014/04/22 23:58:36, Daniel Erat wrote: > add curly brackets Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.cc:582: // By default the top row (F1-F12) keys are special keys for back, forward, On 2014/04/22 23:58:36, Daniel Erat wrote: > s/special/system/g in this section of the code, maybe? (at least, i think that > that's the terminology that's been used elsewhere) Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... File chrome/browser/chromeos/events/event_rewriter.h (right): https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.h:103: int GetRemappedModifierMasks(const PrefService& pref_service, On 2014/04/22 23:58:36, Daniel Erat wrote: > nit: add a comment describing this method Done. https://codereview.chromium.org/248343002/diff/1/chrome/browser/chromeos/even... chrome/browser/chromeos/events/event_rewriter.h:114: MutableKeyState* remapped); On 2014/04/22 23:58:36, Daniel Erat wrote: > nit: maybe rename this to |remapped_state| so it's more distinct from > |remappings| Done.
I am still reviewing the rest of the patch. But I have a question for now: https://codereview.chromium.org/248343002/diff/20001/chrome/browser/chromeos/... File chrome/browser/chromeos/events/event_rewriter.cc (left): https://codereview.chromium.org/248343002/diff/20001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.cc:192: last_device_id_ = device_id; It doesn't look like you are ever setting last_device_id_ in the new code?
On 2014/04/23 19:43:09, sadrul wrote: > I am still reviewing the rest of the patch. But I have a question for now: > > https://codereview.chromium.org/248343002/diff/20001/chrome/browser/chromeos/... > File chrome/browser/chromeos/events/event_rewriter.cc (left): > > https://codereview.chromium.org/248343002/diff/20001/chrome/browser/chromeos/... > chrome/browser/chromeos/events/event_rewriter.cc:192: last_device_id_ = > device_id; > It doesn't look like you are ever setting last_device_id_ in the new code? True, only retained for testing, and expecting issue https://code.google.com/p/chromium/issues/detail?id=360377 to get rid of it entirely, unless you have ideas about it that contradict that.
On 2014/04/23 19:51:07, kpschoedel wrote: > On 2014/04/23 19:43:09, sadrul wrote: > > I am still reviewing the rest of the patch. But I have a question for now: > > > > > https://codereview.chromium.org/248343002/diff/20001/chrome/browser/chromeos/... > > File chrome/browser/chromeos/events/event_rewriter.cc (left): > > > > > https://codereview.chromium.org/248343002/diff/20001/chrome/browser/chromeos/... > > chrome/browser/chromeos/events/event_rewriter.cc:192: last_device_id_ = > > device_id; > > It doesn't look like you are ever setting last_device_id_ in the new code? > > True, only retained for testing, and expecting issue > https://code.google.com/p/chromium/issues/detail?id=360377 to get rid of it > entirely, unless you have ideas about it that contradict that. I would like to make progress in this CL without blocking it on crbug.com/360377. Would it be possible to add defined(USE_X11) guards in this code to make it completely functional on X11, so that we can land this (and https://codereview.chromium.org/240173007/) soon without breaking any existing functionality?
On 2014/04/23 19:54:32, sadrul wrote: > On 2014/04/23 19:51:07, kpschoedel wrote: > > On 2014/04/23 19:43:09, sadrul wrote: > > > I am still reviewing the rest of the patch. But I have a question for now: > > > > > > > > > https://codereview.chromium.org/248343002/diff/20001/chrome/browser/chromeos/... > > > File chrome/browser/chromeos/events/event_rewriter.cc (left): > > > > > > > > > https://codereview.chromium.org/248343002/diff/20001/chrome/browser/chromeos/... > > > chrome/browser/chromeos/events/event_rewriter.cc:192: last_device_id_ = > > > device_id; > > > It doesn't look like you are ever setting last_device_id_ in the new code? > > > > True, only retained for testing, and expecting issue > > https://code.google.com/p/chromium/issues/detail?id=360377 to get rid of it > > entirely, unless you have ideas about it that contradict that. > > I would like to make progress in this CL without blocking it on > crbug.com/360377. Would it be possible to add defined(USE_X11) guards in this > code to make it completely functional on X11, so that we can land this (and > https://codereview.chromium.org/240173007/) soon without breaking any existing > functionality? OK, I'll splice that code back in for now.
lgtm for the nits that i called out, but please wait for sadrul's review https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... File chrome/browser/chromeos/events/event_rewriter.cc (right): https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.cc:213: default: { nit: don't need curly brackets for this one https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.cc:231: if (iter == device_id_to_type_.end()) { nit: can just shorten this to: if (!device_id_to_type_.count(device_id)) https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... File chrome/browser/chromeos/events/event_rewriter.h (right): https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.h:42: : nit: indent this 4 spaces and the base classes 6 spaces
LGTM with a few more nits https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... File chrome/browser/chromeos/events/event_rewriter.cc (right): https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.cc:13: #endif Conditional includes usually go at the end of the regular includes. Can this block be merged with the includes in lines 36-38? https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.cc:254: if (iter == device_id_to_type_.end()) { You can use .count() here too https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.cc:264: bool EventRewriter::HasDiamondKey(const ui::Event& event) const { Does this really need |event| to be passed in? Can this remain as a function in anon namespace until we are able to decide this from the event/device-id? https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.cc:287: for (size_t i = 0; i < arraysize(kModifierRemappings); ++i) { you need to iterate only as long as unmodified_flags is non-zero, right? https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.cc:289: if (unmodified_flags & kModifierRemappings[i].flag) { change this to continue instead. https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.cc:532: ui::EF_COMMAND_DOWN, 4-space indent? Do you mind doing a 'git cl format'? That should fix this kind of formatting issues. https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... File chrome/browser/chromeos/events/event_rewriter.h (right): https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.h:127: bool IsAppleKeyboard(const ui::Event& event) const; ui::KeyEvent https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.h:130: bool HasDiamondKey(const ui::Event& event) const; ditto https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.h:136: bool TopRowKeysAreFunctionKeys(const ui::Event& event) const; ditto
https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... File chrome/browser/chromeos/events/event_rewriter.cc (right): https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.cc:532: ui::EF_COMMAND_DOWN, On 2014/04/25 13:53:27, sadrul wrote: > 4-space indent? > > Do you mind doing a 'git cl format'? That should fix this kind of formatting > issues. OK. I didn't do this earlier to minimize the diffs from the original. https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... File chrome/browser/chromeos/events/event_rewriter.h (right): https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... chrome/browser/chromeos/events/event_rewriter.h:127: bool IsAppleKeyboard(const ui::Event& event) const; On 2014/04/25 13:53:27, sadrul wrote: > ui::KeyEvent This is a ui::Event because (as in the original code) IsAppleKeyboard() gets called from GetRemappedModifierMasks() during the processing of mouse & touch events as well as key events. Then the other two are ui::Event for consistency. But I'll just put IsAppleKeyboard() and HasDiamondKey() back to the original until the device_id changes.
The CQ bit was checked by kpschoedel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/248343002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium
The CQ bit was checked by kpschoedel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/248343002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium
The CQ bit was checked by sadrul@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/248343002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium
The CQ bit was checked by sadrul@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/248343002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium
The CQ bit was checked by sadrul@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/248343002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium linux_chromium_gn_rel on tryserver.chromium
The CQ bit was checked by kpschoedel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/248343002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
Restoring the XEvent send_event test to RewriteEvent() because interactive_ui_tests uses SendKeyEvent(). c.f. comment on https://codereview.chromium.org/237363005/ chrome/browser/chromeos/events/new_event_rewriter.cc line 172 (trybot result http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome... )
The CQ bit was checked by kpschoedel@chromium.org
slgtm. There seems to be some valid lint errors. Do you mind running this through 'git cl format'?
The CQ bit was unchecked by kpschoedel@chromium.org
> There seems to be some valid lint errors. Do you mind running this through 'git > cl format'? clang-format *created* most of those -- see patch set 5. The others are the include order discrepancy from a previous comment https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... -- lint wants them separate.
On 2014/04/30 19:16:29, kpschoedel wrote: > > There seems to be some valid lint errors. Do you mind running this through > 'git > > cl format'? > > clang-format *created* most of those -- see patch set 5. The others are the > include order discrepancy from a previous comment > https://codereview.chromium.org/248343002/diff/80001/chrome/browser/chromeos/... > -- lint wants them separate. Oh, hrm. Let's just fixed the '{//' cases to be '{ //' and then send off to the CQ
Changed comments to please lint. Added non-X11 EventRewriter files to Ozone builds ( following https://codereview.chromium.org/262683003/ ).
The CQ bit was checked by kpschoedel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/248343002/200001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for chrome/chrome_browser_chromeos.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
patching file chrome/chrome_browser_chromeos.gypi
Hunk #1 FAILED at 1081.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/chrome_browser_chromeos.gypi.rej
Patch: chrome/chrome_browser_chromeos.gypi
Index: chrome/chrome_browser_chromeos.gypi
diff --git a/chrome/chrome_browser_chromeos.gypi
b/chrome/chrome_browser_chromeos.gypi
index
320a9fc182fc0c54fbcc6a5c0bd4b2f6c3ba24ef..645582b2292e9206b45ecd2062442a9a692e18c6
100644
--- a/chrome/chrome_browser_chromeos.gypi
+++ b/chrome/chrome_browser_chromeos.gypi
@@ -1081,6 +1081,12 @@
],
'sources/': [
['exclude', '^browser/chromeos/events/'],
+ ['include', '^browser/chromeos/events/event_rewriter.cc'],
+ ['include', '^browser/chromeos/events/event_rewriter.h'],
+ ['include',
'^browser/chromeos/events/event_rewriter_controller.cc'],
+ ['include',
'^browser/chromeos/events/event_rewriter_controller.h'],
+ ['include',
'^browser/chromeos/events/keyboard_driven_event_rewriter.cc'],
+ ['include',
'^browser/chromeos/events/keyboard_driven_event_rewriter.h'],
],
}],
],
The CQ bit was checked by kpschoedel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/248343002/200001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for chrome/chrome_browser_chromeos.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
patching file chrome/chrome_browser_chromeos.gypi
Hunk #1 FAILED at 1081.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/chrome_browser_chromeos.gypi.rej
Patch: chrome/chrome_browser_chromeos.gypi
Index: chrome/chrome_browser_chromeos.gypi
diff --git a/chrome/chrome_browser_chromeos.gypi
b/chrome/chrome_browser_chromeos.gypi
index
320a9fc182fc0c54fbcc6a5c0bd4b2f6c3ba24ef..645582b2292e9206b45ecd2062442a9a692e18c6
100644
--- a/chrome/chrome_browser_chromeos.gypi
+++ b/chrome/chrome_browser_chromeos.gypi
@@ -1081,6 +1081,12 @@
],
'sources/': [
['exclude', '^browser/chromeos/events/'],
+ ['include', '^browser/chromeos/events/event_rewriter.cc'],
+ ['include', '^browser/chromeos/events/event_rewriter.h'],
+ ['include',
'^browser/chromeos/events/event_rewriter_controller.cc'],
+ ['include',
'^browser/chromeos/events/event_rewriter_controller.h'],
+ ['include',
'^browser/chromeos/events/keyboard_driven_event_rewriter.cc'],
+ ['include',
'^browser/chromeos/events/keyboard_driven_event_rewriter.h'],
],
}],
],
Sync with master.
The CQ bit was checked by kpschoedel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/248343002/220001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
All hail the glorious trybots.
The CQ bit was checked by kpschoedel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/248343002/240001
Message was sent while issue was closed.
Change committed as 267578 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
