HTTP Bad: Split out UMA metrics for password vs credit card "Not secure" warnings

chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc

Index: chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc b/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
index 4c95eb6943222c9c2e7061eec1c3c2d89b6b5c7f..08768ec4ca10595b2d84a7dfd7742ff5a9fe239d 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
@@ -1314,7 +1314,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest, ConsoleMessage) {
   client->GetSecurityInfo(&security_info);
   EXPECT_EQ(security_state::SecurityStateModel::NONE,
             security_info.security_level);
-  EXPECT_TRUE(security_info.displayed_private_user_data_input_on_http);
+  EXPECT_TRUE(security_info.displayed_password_field_on_http);
 
   // Check that the expected console message is present.
   ASSERT_NO_FATAL_FAILURE(CheckForOneFutureHttpWarningConsoleMessage(delegate));
@@ -1339,7 +1339,8 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest, ConsoleMessage) {
   client->GetSecurityInfo(&security_info);
   EXPECT_EQ(security_state::SecurityStateModel::NONE,
             security_info.security_level);
-  EXPECT_TRUE(security_info.displayed_private_user_data_input_on_http);
+  EXPECT_TRUE(security_info.displayed_password_field_on_http);
+  EXPECT_FALSE(security_info.displayed_credit_card_field_on_http);
 

[estark, 2016/11/09 15:56:46]

Could you please add a section here at the end of this test that navigates to
title1.html and calls contents->OnCreditCardInputShownOnHttp() and waits for a
console message? Basically repeating lines 1327-1343 except navigating to
title1.html and setting a credit card instead of a password.

[lshang, 2016/11/10 04:53:54]

Done.

   ASSERT_NO_FATAL_FAILURE(CheckForOneFutureHttpWarningConsoleMessage(delegate));
 }