Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2483413002: Revert of Use mojo support for Blink devicechange event. (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use mojo support for Blink devicechange event. (patchset #3 id:120001 of https://codereview.chromium.org/2476153002/ ) Reason for revert: Reverting due to this CL due to it blocking the revert of another CL that is interfering with perf tests. Will reland after that. See crbug.com/662414 Original issue's description: > Use mojo support for Blink devicechange event. > > BUG=648183 > > Committed: https://crrev.com/6a0339c962198b75c333eb14bafa6374890d738a > Cr-Commit-Position: refs/heads/master@{#430318} TBR=hbos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=648183 Committed: https://crrev.com/d9a27e0a82856485f39a73863431211475bf8789 Cr-Commit-Position: refs/heads/master@{#430899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -82 lines) Patch
M content/renderer/media/user_media_client_impl.h View 4 chunks +1 line, -9 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 3 chunks +6 lines, -28 lines 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 7 chunks +15 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Guido Urdaneta
Created Revert of Use mojo support for Blink devicechange event.
4 years, 1 month ago (2016-11-09 08:24:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483413002/1
4 years, 1 month ago (2016-11-09 08:24:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 09:12:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d9a27e0a82856485f39a73863431211475bf8789 Cr-Commit-Position: refs/heads/master@{#430899}
4 years, 1 month ago (2016-11-09 09:15:00 UTC) #7
Guido Urdaneta
4 years, 1 month ago (2016-11-09 09:18:54 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2488843003/ by guidou@chromium.org.

The reason for reverting is: Relanding since the relanding of
MediaStreamTrack.getSources (the ermoval of which is interfering with perf
tests) will have to be manual anyway..

Powered by Google App Engine
This is Rietveld 408576698