Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2483363002: clang-formats remaining files and adds a presubmit check. (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add clang_format script to DEPS #

Patch Set 3 : Format more files. Disable cpplint whitespace check. #

Patch Set 4 : Format include file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -211 lines) Patch
M DEPS View 1 3 chunks +19 lines, -0 lines 0 comments Download
M runtime/CPPLINT.cfg View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/PRESUBMIT.py View 1 chunk +8 lines, -2 lines 0 comments Download
M runtime/bin/loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/include/dart_api.h View 1 2 26 chunks +97 lines, -100 lines 0 comments Download
M runtime/include/dart_mirrors_api.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/include/dart_native_api.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/include/dart_tools_api.h View 1 2 3 22 chunks +61 lines, -75 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 2 1 chunk +3 lines, -8 lines 0 comments Download
M runtime/vm/object_store.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 1 chunk +12 lines, -6 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 4 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 1 month ago (2016-11-09 17:40:15 UTC) #2
siva
lgtm
4 years, 1 month ago (2016-11-09 19:01:51 UTC) #3
Cutch
lgtm
4 years, 1 month ago (2016-11-09 19:04:43 UTC) #4
zra
4 years, 1 month ago (2016-11-09 20:44:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
630d24bec8ed4b8f61013904265d68fe91f72704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698