Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2483353002: Add BUILD.gn for pkg/front_end to fix the Fuchsia build (Closed)

Created:
4 years, 1 month ago by ianloic
Modified:
4 years, 1 month ago
Reviewers:
abarth, Paul Berry, zra
CC:
reviews_dartlang.org, lanechr
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add BUILD.gn for pkg/front_end to fix the Fuchsia build BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/5f8580a6738187c299797d573214b5a87b7144e4

Patch Set 1 #

Patch Set 2 : Add BUILD.gn for pkg/front_end to fix the Fuchsia build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M pkg/analyzer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/front_end/BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ianloic
4 years, 1 month ago (2016-11-08 22:46:29 UTC) #2
Paul Berry
lgtm
4 years, 1 month ago (2016-11-08 22:48:35 UTC) #3
zra
I wonder if these package build files should be in Fuchsia's //build/secondary since they are ...
4 years, 1 month ago (2016-11-08 22:52:12 UTC) #4
ianloic
I apparently don't have permission to land this on github :(
4 years, 1 month ago (2016-11-08 23:06:15 UTC) #5
ianloic
+lanechr FYI
4 years, 1 month ago (2016-11-08 23:11:30 UTC) #6
zra
4 years, 1 month ago (2016-11-08 23:15:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5f8580a6738187c299797d573214b5a87b7144e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698