Add patch file support to the analyzer task model.

Add patch file support to the analyzer task model.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/5eb3636ae38adc32cf3eafb9e3356836c83d463a

[Paul Berry, 2016-11-08 21:18:39]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-11-08 21:24:30]

lgtm

https://codereview.chromium.org/2483343002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/2483343002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:1456: int encodeCrossContextOptions()
=>
I think this, setCrossContextOptionsFrom, and decodeCrossContextOptions need to
include a notion of patchPlatform. This is used to determine whether we need a
different context for a set of sources (such as an SDK) because of the way the
code will be analyzed, and I think applying a different patch platform would
qualify.

[Paul Berry, 2016-11-08 21:56:19]

https://codereview.chromium.org/2483343002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/2483343002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:1456: int encodeCrossContextOptions()
=>
On 2016/11/08 21:24:30, Brian Wilkerson wrote:
> I think this, setCrossContextOptionsFrom, and decodeCrossContextOptions need
to
> include a notion of patchPlatform. This is used to determine whether we need a
> different context for a set of sources (such as an SDK) because of the way the
> code will be analyzed, and I think applying a different patch platform would
> qualify.

Good catch.  As discussed in person, I will address this in a follow-up CL.

[Paul Berry, 2016-11-08 22:00:48]

Description was changed from

==========
Add patch file support to the analyzer task model.
==========

to

==========
Add patch file support to the analyzer task model.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5eb3636ae38adc32cf3eafb9e3356836c83d463a
==========

[Paul Berry, 2016-11-08 22:00:49]

Committed patchset #1 (id:1) manually as
5eb3636ae38adc32cf3eafb9e3356836c83d463a (presubmit successful).