Chromium Code Reviews
DescriptionRevert of DevTools: isolate settings of custom devtoools front-end. (patchset #3 id:40001 of https://codereview.chromium.org/2474563002/ )
Reason for revert:
Reverting this patchset since it doesn't fully address problem. LocalStorage settings still clash.
Original issue's description:
> DevTools: isolate settings of custom devtoools front-end.
>
> Currently, changing a setting inside custom devtools front-end (the one
> served through chrome-devtools://devtools/custom) will change the same
> setting inside bundled devtools.
>
> This is unfortunate. In the setup we aim for, the custom devtools
> are inspected by the bundled devtools, and we want them to be
> independent of each other.
>
> This patch starts using local storage for the settings of the
> chrome-devtools://devtools/custom front-end.
>
> Note: settings will be isolated, whereas experiments won't.
>
> BUG=629914
> R=dgozman
>
> Committed: https://crrev.com/16056dbccd68723d61feaf6e9a9518a300485c2c
> Cr-Commit-Position: refs/heads/master@{#429414}
TBR=dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=629914
Committed: https://crrev.com/06d6b72bec8b7a0d1edc53b7597eb1a5acb78285
Cr-Commit-Position: refs/heads/master@{#430814}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||