Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2483333003: Revert of DevTools: isolate settings of custom devtoools front-end. (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: isolate settings of custom devtoools front-end. (patchset #3 id:40001 of https://codereview.chromium.org/2474563002/ ) Reason for revert: Reverting this patchset since it doesn't fully address problem. LocalStorage settings still clash. Original issue's description: > DevTools: isolate settings of custom devtoools front-end. > > Currently, changing a setting inside custom devtools front-end (the one > served through chrome-devtools://devtools/custom) will change the same > setting inside bundled devtools. > > This is unfortunate. In the setup we aim for, the custom devtools > are inspected by the bundled devtools, and we want them to be > independent of each other. > > This patch starts using local storage for the settings of the > chrome-devtools://devtools/custom front-end. > > Note: settings will be isolated, whereas experiments won't. > > BUG=629914 > R=dgozman > > Committed: https://crrev.com/16056dbccd68723d61feaf6e9a9518a300485c2c > Cr-Commit-Position: refs/heads/master@{#429414} TBR=dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629914 Committed: https://crrev.com/06d6b72bec8b7a0d1edc53b7597eb1a5acb78285 Cr-Commit-Position: refs/heads/master@{#430814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
lushnikov
Created Revert of DevTools: isolate settings of custom devtoools front-end.
4 years, 1 month ago (2016-11-08 23:52:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483333003/1
4 years, 1 month ago (2016-11-08 23:53:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 01:45:30 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 01:51:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06d6b72bec8b7a0d1edc53b7597eb1a5acb78285
Cr-Commit-Position: refs/heads/master@{#430814}

Powered by Google App Engine
This is Rietveld 408576698