Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 248333002: Remove AutocompleteResultErrorUnsupported, replace with AutocompleteResultErrorDisabled (Closed)

Created:
6 years, 8 months ago by Evan Stade
Modified:
6 years, 8 months ago
Reviewers:
aruslan1, aruslan
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Remove AutocompleteResultErrorUnsupported, replace with AutocompleteResultErrorDisabled After discussion with ianh, we decided it wasn't helpful to add Unsupported to the rAc spec after all. BUG=347832 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/content/browser/request_autocomplete_manager.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Evan Stade
6 years, 8 months ago (2014-04-24 22:06:53 UTC) #1
aruslan1
lgtm
6 years, 8 months ago (2014-04-24 22:19:40 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-24 22:29:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/248333002/1
6 years, 8 months ago (2014-04-24 22:30:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:59:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 22:59:02 UTC) #6
aruslan
lgtm from a correct account.
6 years, 8 months ago (2014-04-24 23:00:50 UTC) #7
aruslan
The CQ bit was checked by aruslan@chromium.org
6 years, 8 months ago (2014-04-24 23:00:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/248333002/1
6 years, 8 months ago (2014-04-24 23:01:41 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 23:27:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-24 23:27:35 UTC) #11
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-25 01:01:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/248333002/1
6 years, 8 months ago (2014-04-25 01:02:54 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 07:35:59 UTC) #14
Message was sent while issue was closed. 
Change committed as 266150

Powered by Google App Engine
This is Rietveld 408576698