[ios] Create NativeAppTypes class

[ios] Create NativeAppTypes class

This class contains enums that will be used by native_app_launcher
classes.

BUG=662573
Committed: https://crrev.com/a720602de2706c6bc5a47e3bee207e9d52e669e2
Cr-Commit-Position: refs/heads/master@{#431055}

[sczs1, 2016-11-09 06:16:54]

The CQ bit was checked by sczs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 06:17:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 06:19:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 06:19:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sczs1, 2016-11-09 06:20:01]

The CQ bit was unchecked by sczs@google.com

[sczs1, 2016-11-09 06:21:02]

sczs@google.com changed reviewers:
+ rohitrao@chromium.org

[sczs1, 2016-11-09 06:21:03]

PTAL

[rohitrao (ping after 24h), 2016-11-09 09:52:44]

https://codereview.chromium.org/2483303003/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/native_app_launcher/native_app_types.h
(right):

https://codereview.chromium.org/2483303003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/native_app_launcher/native_app_types.h:11:
enum ActionType {
If we rename this to NativeAppActionType, then we could remove the "class
NativeAppTypes" entirely, because the enums themselves will have unique names.

https://codereview.chromium.org/2483303003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/native_app_launcher/native_app_types.h:12:
USER_ACTION_IGNORE,
Rename these from USER_ACTION* to NATIVE_APP_ACTION_*

[sczs1, 2016-11-09 17:11:54]

Hi Rohit,

Made the changes, could you PTAL

https://codereview.chromium.org/2483303003/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/native_app_launcher/native_app_types.h
(right):

https://codereview.chromium.org/2483303003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/native_app_launcher/native_app_types.h:11:
enum ActionType {
On 2016/11/09 09:52:44, rohitrao wrote:
> If we rename this to NativeAppActionType, then we could remove the "class
> NativeAppTypes" entirely, because the enums themselves will have unique names.

Sounds like a good idea. Done.

https://codereview.chromium.org/2483303003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/native_app_launcher/native_app_types.h:12:
USER_ACTION_IGNORE,
On 2016/11/09 09:52:44, rohitrao wrote:
> Rename these from USER_ACTION* to NATIVE_APP_ACTION_*

Done.

[rohitrao (ping after 24h), 2016-11-09 20:34:06]

lgtm

Please add pkl@chromium.org and lpromero@chromium.org to an OWNERS file in this
directory.

[rohitrao (ping after 24h), 2016-11-09 20:34:42]

Actually, you could just roll this in with your other CL.  There's no need to
split it out unless you want to.

[sczs1, 2016-11-09 21:01:37]

The CQ bit was checked by sczs@google.com

[sczs1, 2016-11-09 21:02:05]

On 2016/11/09 20:34:42, rohitrao wrote:
> Actually, you could just roll this in with your other CL.  There's no need to
> split it out unless you want to.

Ok, will make the change in the other CL.

[commit-bot: I haz the power, 2016-11-09 21:02:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 21:05:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 21:05:44]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sczs1, 2016-11-09 21:23:02]

The CQ bit was checked by sczs@google.com

[sczs1, 2016-11-09 21:23:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2483303003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-09 21:23:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 22:35:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-09 22:42:22]

Description was changed from

==========
[ios] Create NativeAppTypes class

This class contains enums that will be used by native_app_launcher
classes.

BUG=662573
==========

to

==========
[ios] Create NativeAppTypes class

This class contains enums that will be used by native_app_launcher
classes.

BUG=662573

Committed: https://crrev.com/a720602de2706c6bc5a47e3bee207e9d52e669e2
Cr-Commit-Position: refs/heads/master@{#431055}
==========

[commit-bot: I haz the power, 2016-11-09 22:42:22]

Patchset 3 (id:??) landed as
https://crrev.com/a720602de2706c6bc5a47e3bee207e9d52e669e2
Cr-Commit-Position: refs/heads/master@{#431055}