Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp

Issue 2483243003: Re-enable image_decode_bench target (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp
diff --git a/third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp b/third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp
index 8aa6b4a00b523327313f82aed2798e377cf63bf4..d490989e988afe0738edc7bcfdf5c082bcc5ce85 100644
--- a/third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp
+++ b/third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp
@@ -258,10 +258,10 @@ PassRefPtr<SharedBuffer> readFile(const char* fileName) {
bool decodeImageData(SharedBuffer* data,
bool colorCorrection,
size_t packetSize) {
- std::unique_ptr<ImageDecoder> decoder = ImageDecoder::create(
- *data, ImageDecoder::AlphaPremultiplied,
- colorCorrection ? ImageDecoder::GammaAndColorProfileApplied
- : ImageDecoder::GammaAndColorProfileIgnored);
+ std::unique_ptr<ImageDecoder> decoder =
+ ImageDecoder::create(data, true, ImageDecoder::AlphaPremultiplied,
+ colorCorrection ? ImageDecoder::ColorSpaceApplied
+ : ImageDecoder::ColorSpaceIgnored);
if (!packetSize) {
bool allDataReceived = true;
@@ -350,12 +350,7 @@ int main(int argc, char* argv[]) {
// Create a web platform without V8.
- class WebPlatform : public blink::Platform {
- public:
- void screenColorProfile(WebVector<char>* profile) override {
- getScreenColorProfile(profile); // Returns a color spin color profile.
scroggo_chromium 2016/11/09 14:16:59 msarett@, do you know the right way to set this no
msarett1 2016/11/09 15:01:58 I'm not aware that this has changed. The profile
Simon Hosie 2016/11/09 17:29:13 The method it overrides was deleted in https://chr
msarett1 2016/11/09 18:18:28 Ahh thanks! It looks to me like now instead we ca
- }
- };
+ class WebPlatform : public blink::Platform {};
Platform::initialize(new WebPlatform());
« no previous file with comments | « third_party/WebKit/Source/platform/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698