Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2483243002: Fixed crash when compiling without linking. (Closed)

Created:
4 years, 1 month ago by jensj
Modified:
4 years, 1 month ago
Reviewers:
asgerf
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed crash when compiling without linking. Since offsets and uris was added to the dill file, compiling to dill without linking hasn't worked because of external libraries. The external libraries doesn't add to the line starts table and thus the uris from libraries, classes and so on isn't recorded. When trying to write an unrecorded uri to the dill file it fails. The simple solution applied here is to fall-back to the empty string when the uri hasn't been recorded. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/kernel/commit/b044c217f5f96e30828f9e6adf6cd9e58364021d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M lib/binary/ast_to_binary.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
jensj
4 years, 1 month ago (2016-11-08 13:37:12 UTC) #2
asgerf
CL description: The "dummy loads" are called external libraries. There is no reason to call ...
4 years, 1 month ago (2016-11-08 13:44:38 UTC) #3
jensj
4 years, 1 month ago (2016-11-08 13:54:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b044c217f5f96e30828f9e6adf6cd9e58364021d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698