Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 248323004: Hook up WebKit WTF to GN build. (Closed)

Created:
6 years, 8 months ago by brettw
Modified:
6 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Hook up WebKit WTF to GN build. This also moves the "use clang plugins" flag to a GNI file so it can be shared (WebKit needs to read this flag). TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265940

Patch Set 1 #

Patch Set 2 : whitespace #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/config/clang/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
A build/config/clang/clang.gni View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 8 months ago (2014-04-24 16:42:52 UTC) #1
brettw
Committed patchset #3 manually as r265940 (presubmit successful).
6 years, 8 months ago (2014-04-24 16:44:10 UTC) #2
scottmg
6 years, 8 months ago (2014-04-24 17:02:45 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698