Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2483213010: Validate that the expressions in an assert in the initializer list of a const constructor are all p… (Closed)

Created:
4 years, 1 month ago by Brian Wilkerson
Modified:
4 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Validate that the expressions in an assert in the initializer list of a const constructor are all potentially const expressions R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f8aebca4c9afebff7a8190d91c78c9469b38a80e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -9 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +12 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 1 month ago (2016-11-11 16:47:22 UTC) #2
scheglov
LGTM
4 years, 1 month ago (2016-11-11 17:25:30 UTC) #3
Brian Wilkerson
4 years, 1 month ago (2016-11-11 17:31:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8aebca4c9afebff7a8190d91c78c9469b38a80e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698