Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 2483213003: Add chrome_modern_public_apk target (Closed)

Created:
4 years, 1 month ago by agrieve
Modified:
4 years, 1 month ago
Reviewers:
michaelbai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome_modern_public_apk target This adds an upstream equivalent to ChromeModern.apk, which is sent to devices with Android L & M. It differs from ChromePublic.apk only by having the native library stored uncompressed (besides setting the minSdkVersion). BUG=650927 Committed: https://crrev.com/be18d7c8226d8949d9b840a99b365e032697becf Cr-Commit-Position: refs/heads/master@{#430931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/android/BUILD.gn View 4 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
agrieve
On 2016/11/08 18:42:32, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:michaelbai@chromium.org 🐳
4 years, 1 month ago (2016-11-08 18:42:41 UTC) #3
michaelbai
LGTM FYI, I am working at Monochrome part.
4 years, 1 month ago (2016-11-08 18:52:05 UTC) #4
agrieve
On 2016/11/08 18:52:05, michaelbai wrote: > LGTM > > FYI, I am working at Monochrome ...
4 years, 1 month ago (2016-11-08 19:14:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483213003/1
4 years, 1 month ago (2016-11-08 19:14:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/313402)
4 years, 1 month ago (2016-11-08 20:09:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483213003/1
4 years, 1 month ago (2016-11-09 14:19:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 15:06:42 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 15:08:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be18d7c8226d8949d9b840a99b365e032697becf
Cr-Commit-Position: refs/heads/master@{#430931}

Powered by Google App Engine
This is Rietveld 408576698