Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2483203002: Always install the microdump signal handler on N+ devices. (Closed)

Created:
4 years, 1 month ago by Tobias Sargeant
Modified:
4 years, 1 month ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always install the microdump signal handler on N+ devices. N+ shared library namespacing means that the current detection code that determines whether it is safe to install the microdump signal handler fails, because it is impossible to dlopen libnativebridge (because it isn't in the NDK). Because the libnativebridge on N+ devices is sufficiently recent as to not need the test, we simply short-circuit on those devices. BUG=662853 Committed: https://crrev.com/2c944c9e76acc4e22a67bff89e33afd2342db0a1 Cr-Commit-Position: refs/heads/master@{#430713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M android_webview/crash_reporter/aw_microdump_crash_reporter.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M base/android/build_info.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Torne
lgtm
4 years, 1 month ago (2016-11-08 14:36:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483203002/1
4 years, 1 month ago (2016-11-08 20:05:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 21:10:40 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 21:15:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c944c9e76acc4e22a67bff89e33afd2342db0a1
Cr-Commit-Position: refs/heads/master@{#430713}

Powered by Google App Engine
This is Rietveld 408576698