Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2483193002: [wasm] Wrap start function in a JS->WASM wrapper before calling it during initialization. (Closed)

Created:
4 years, 1 month ago by titzer
Modified:
4 years, 1 month ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Wrap start function in a JS->WASM wrapper before calling it during initialization. BUG=v8:5599 R=ahaas@chromium.org Committed: https://crrev.com/68fdaf6dea640653fe8566e748d0713501a7fb43 Cr-Commit-Position: refs/heads/master@{#40830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M src/wasm/wasm-module.cc View 1 chunk +7 lines, -1 line 0 comments Download
M test/mjsunit/wasm/start-function.js View 1 chunk +20 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
titzer
4 years, 1 month ago (2016-11-08 12:05:52 UTC) #1
ahaas
lgtm
4 years, 1 month ago (2016-11-08 12:19:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483193002/1
4 years, 1 month ago (2016-11-08 12:34:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 12:36:28 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68fdaf6dea640653fe8566e748d0713501a7fb43
Cr-Commit-Position: refs/heads/master@{#40830}

Powered by Google App Engine
This is Rietveld 408576698