Build v8 snapshot with correct default float configuration on Linux ARM

Build v8 snapshot with correct default float configuration on Linux ARM

V8 currently defaults to arm_float_abi="hard" and arm_use_neon=true but
the V8 snapshot defaults to arm_float_abi="softfp" and arm_use_neon=false
on Linux ARM builds.

This patch makes both targets default to hard + neon by changing the
"is simulator build" check from comparing current_cpu with v8_current_cpu
to comparing target_cpu with v8_target_cpu instead. Similarly to how it is
checked in v8/BUILD.gn.

BUG=662856
Committed: https://crrev.com/2c53ba1d955a7da25dbf63829b8e7052e7bf0ceb
Cr-Commit-Position: refs/heads/master@{#430776}

[rogerj, 2016-11-08 12:59:11]

Description was changed from

==========
Build v8 snapshot with correct default float configuration on Linux ARM

V8 currently defaults to arm_float_abi="hard" and arm_use_neon=true but
the V8 snapshot defaults to arm_float_abi="softfp" and arm_use_neon=false
on Linux ARM builds.

This patch makes both targets default to hard + neon by changing the
"is simulator build" check from comparing current_cpu with v8_current_cpu
to comparing target_cpu with v8_target_cpu instead. Similarly to how it is
checked in v8/BUILD.gn.

BUG=662856
==========

to

==========
Build v8 snapshot with correct default float configuration on Linux ARM

V8 currently defaults to arm_float_abi="hard" and arm_use_neon=true but
the V8 snapshot defaults to arm_float_abi="softfp" and arm_use_neon=false
on Linux ARM builds.

This patch makes both targets default to hard + neon by changing the
"is simulator build" check from comparing current_cpu with v8_current_cpu
to comparing target_cpu with v8_target_cpu instead. Similarly to how it is
checked in v8/BUILD.gn.

BUG=662856
==========

[rogerj, 2016-11-08 12:59:12]

rogerj@opera.com changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-11-08 22:05:45]

lgtm

[Dirk Pranke, 2016-11-08 22:06:00]

dpranke@chromium.org changed reviewers:
+ machenbach@google.com

[Dirk Pranke, 2016-11-08 22:06:09]

dpranke@chromium.org changed reviewers:
+ machenbach@chromium.org
- machenbach@google.com

[rogerj, 2016-11-08 22:23:43]

The CQ bit was checked by rogerj@opera.com

[commit-bot: I haz the power, 2016-11-08 22:24:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 00:00:55]

Description was changed from

==========
Build v8 snapshot with correct default float configuration on Linux ARM

V8 currently defaults to arm_float_abi="hard" and arm_use_neon=true but
the V8 snapshot defaults to arm_float_abi="softfp" and arm_use_neon=false
on Linux ARM builds.

This patch makes both targets default to hard + neon by changing the
"is simulator build" check from comparing current_cpu with v8_current_cpu
to comparing target_cpu with v8_target_cpu instead. Similarly to how it is
checked in v8/BUILD.gn.

BUG=662856
==========

to

==========
Build v8 snapshot with correct default float configuration on Linux ARM

V8 currently defaults to arm_float_abi="hard" and arm_use_neon=true but
the V8 snapshot defaults to arm_float_abi="softfp" and arm_use_neon=false
on Linux ARM builds.

This patch makes both targets default to hard + neon by changing the
"is simulator build" check from comparing current_cpu with v8_current_cpu
to comparing target_cpu with v8_target_cpu instead. Similarly to how it is
checked in v8/BUILD.gn.

BUG=662856
==========

[commit-bot: I haz the power, 2016-11-09 00:01:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-09 00:08:17]

Description was changed from

==========
Build v8 snapshot with correct default float configuration on Linux ARM

V8 currently defaults to arm_float_abi="hard" and arm_use_neon=true but
the V8 snapshot defaults to arm_float_abi="softfp" and arm_use_neon=false
on Linux ARM builds.

This patch makes both targets default to hard + neon by changing the
"is simulator build" check from comparing current_cpu with v8_current_cpu
to comparing target_cpu with v8_target_cpu instead. Similarly to how it is
checked in v8/BUILD.gn.

BUG=662856
==========

to

==========
Build v8 snapshot with correct default float configuration on Linux ARM

V8 currently defaults to arm_float_abi="hard" and arm_use_neon=true but
the V8 snapshot defaults to arm_float_abi="softfp" and arm_use_neon=false
on Linux ARM builds.

This patch makes both targets default to hard + neon by changing the
"is simulator build" check from comparing current_cpu with v8_current_cpu
to comparing target_cpu with v8_target_cpu instead. Similarly to how it is
checked in v8/BUILD.gn.

BUG=662856

Committed: https://crrev.com/2c53ba1d955a7da25dbf63829b8e7052e7bf0ceb
Cr-Commit-Position: refs/heads/master@{#430776}
==========

[commit-bot: I haz the power, 2016-11-09 00:08:18]

Patchset 1 (id:??) landed as
https://crrev.com/2c53ba1d955a7da25dbf63829b8e7052e7bf0ceb
Cr-Commit-Position: refs/heads/master@{#430776}

[Michael Achenbach, 2016-11-09 07:53:40]

lgtm