Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 248313003: Remove Hack used in blink side for merging dependent chromium and blink patches. (Closed)

Created:
6 years, 8 months ago by Sunil Ratnu
Modified:
6 years, 8 months ago
Reviewers:
jamesr, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove Hack used in blink side for merging dependent chromium and blink patches. To merge the dependent patches https://codereview.chromium.org/137893025/ and https://codereview.chromium.org/138523003/ , older definition of the function didActivateCompositor() was also needed to be kept at both chromium and blink side. This was introduced in https://codereview.chromium.org/189263019/ . Since all of the patches have landed now, we can land this final patch which removes the older definitions from the blink side. BUG=None TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M public/web/WebWidgetClient.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sunil Ratnu
Please have a look.
6 years, 8 months ago (2014-04-23 06:00:20 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-23 17:23:29 UTC) #2
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 8 months ago (2014-04-23 18:52:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/248313003/1
6 years, 8 months ago (2014-04-23 18:53:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 19:09:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-23 19:10:00 UTC) #6
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 8 months ago (2014-04-23 20:14:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/248313003/1
6 years, 8 months ago (2014-04-23 20:14:14 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 21:35:39 UTC) #9
Message was sent while issue was closed.
Change committed as 172415

Powered by Google App Engine
This is Rietveld 408576698