Disable scrollbar snapback on desktop Linux (Reland)

Disable scrollbar snapback on desktop Linux (Reland)

This CL disables scrollbar snapback to be more consistent with typical
desktop Linux UI.  Additionally, rename
webscrollbarbehavior_impl_gtkoraura* to
webscrollbarbehavior_impl_aura* since there's no longer a GTK backend
for Linux Chromium.

BUG=567968
Committed: https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f
Committed: https://crrev.com/fd0d31facac27b29b5c60fc41f05fd4ca8486c6a
Cr-Original-Commit-Position: refs/heads/master@{#430994}
Cr-Commit-Position: refs/heads/master@{#432556}

[Tom (Use chromium acct), 2016-11-08 02:49:24]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 02:50:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2016-11-08 02:50:34]

thomasanderson@google.com changed reviewers:
+ clamy@chromium.org

[Tom (Use chromium acct), 2016-11-08 02:50:34]

clamy@ PTAL or reassign to a different reviewer (there were lots of options in
git cl owners)
pkasting@ FYI

[Peter Kasting, 2016-11-08 02:59:13]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2016-11-08 02:59:14]

https://codereview.chromium.org/2483113002/diff/1/content/renderer/webscrollb...
File content/renderer/webscrollbarbehavior_impl_aura.cc (right):

https://codereview.chromium.org/2483113002/diff/1/content/renderer/webscrollb...
content/renderer/webscrollbarbehavior_impl_aura.cc:29: // Disable snapback on
desktop Linux.  See crbug.com/567968 for context.
FWIW, I'd omit the bug link and simply summarize here in a sentence or two why
we shouldn't do that on Linux.  That will be clearer than trying to decipher
from a bug with lots of comments which parts are relevant "context", especially
when you haven't actually posted on that bug with your rationale (and our IM
discussions aren't captured there either).

[Tom (Use chromium acct), 2016-11-08 03:07:45]

Fixed out-of-date "#endif  //
CONTENT_RENDERER_WEBSCROLLBARBEHAVIOR_IMPL_GTKORAURA_H_"

https://codereview.chromium.org/2483113002/diff/1/content/renderer/webscrollb...
File content/renderer/webscrollbarbehavior_impl_aura.cc (right):

https://codereview.chromium.org/2483113002/diff/1/content/renderer/webscrollb...
content/renderer/webscrollbarbehavior_impl_aura.cc:29: // Disable snapback on
desktop Linux.  See crbug.com/567968 for context.
On 2016/11/08 02:59:13, Peter Kasting wrote:
> FWIW, I'd omit the bug link and simply summarize here in a sentence or two why
> we shouldn't do that on Linux.  That will be clearer than trying to decipher
> from a bug with lots of comments which parts are relevant "context",
especially
> when you haven't actually posted on that bug with your rationale (and our IM
> discussions aren't captured there either).

Done.

[Tom (Use chromium acct), 2016-11-08 23:52:17]

Pinging clamy@

[clamy, 2016-11-09 14:32:06]

Thanks! Lgtm.

[Tom (Use chromium acct), 2016-11-09 17:22:46]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-11-09 17:23:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 18:55:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-09 19:17:08]

Description was changed from

==========
Disable scrollbar snapback on desktop Linux

This CL disables scrollbar snapback to be more consistent with typical
desktop Linux UI.  Additionally, rename
webscrollbarbehavior_impl_gtkoraura* to
webscrollbarbehavior_impl_aura* since there's no longer a GTK backend
for Linux Chromium.

BUG=567968
==========

to

==========
Disable scrollbar snapback on desktop Linux

This CL disables scrollbar snapback to be more consistent with typical
desktop Linux UI.  Additionally, rename
webscrollbarbehavior_impl_gtkoraura* to
webscrollbarbehavior_impl_aura* since there's no longer a GTK backend
for Linux Chromium.

BUG=567968

Committed: https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f
Cr-Commit-Position: refs/heads/master@{#430994}
==========

[commit-bot: I haz the power, 2016-11-09 19:17:09]

Patchset 2 (id:??) landed as
https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f
Cr-Commit-Position: refs/heads/master@{#430994}

[Dirk Pranke, 2016-11-09 19:53:22]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2489083002/ by dpranke@chromium.org.

The reason for reverting is: Looks like this broke a layout test:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precis...
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Pre...

So I'm reverting it. Sorry! It is unfortunate that we don't run the layout tests
on all content changes yet :(..

[Tom (Use chromium acct), 2016-11-09 23:15:31]

Description was changed from

==========
Disable scrollbar snapback on desktop Linux

This CL disables scrollbar snapback to be more consistent with typical
desktop Linux UI.  Additionally, rename
webscrollbarbehavior_impl_gtkoraura* to
webscrollbarbehavior_impl_aura* since there's no longer a GTK backend
for Linux Chromium.

BUG=567968

Committed: https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f
Cr-Commit-Position: refs/heads/master@{#430994}
==========

to

==========
Disable scrollbar snapback on desktop Linux (Reland)

This CL disables scrollbar snapback to be more consistent with typical
desktop Linux UI.  Additionally, rename
webscrollbarbehavior_impl_gtkoraura* to
webscrollbarbehavior_impl_aura* since there's no longer a GTK backend
for Linux Chromium.

BUG=567968

Committed: https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f
Cr-Commit-Position: refs/heads/master@{#430994}
==========

[Tom (Use chromium acct), 2016-11-09 23:15:41]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 23:16:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 03:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 03:22:35]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Tom (Use chromium acct), 2016-11-15 21:55:46]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 21:56:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 22:28:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:28:33]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Tom (Use chromium acct), 2016-11-16 01:13:14]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-11-16 01:13:14]

The patchset sent to the CQ was uploaded after l-g-t-m from clamy@chromium.org
Link to the patchset: https://codereview.chromium.org/2483113002/#ps60001
(title: "Update test comment")

[commit-bot: I haz the power, 2016-11-16 01:13:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 02:41:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 02:41:23]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Tom (Use chromium acct), 2016-11-16 18:05:36]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-11-16 18:06:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 18:16:14]

Description was changed from

==========
Disable scrollbar snapback on desktop Linux (Reland)

This CL disables scrollbar snapback to be more consistent with typical
desktop Linux UI.  Additionally, rename
webscrollbarbehavior_impl_gtkoraura* to
webscrollbarbehavior_impl_aura* since there's no longer a GTK backend
for Linux Chromium.

BUG=567968

Committed: https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f
Cr-Commit-Position: refs/heads/master@{#430994}
==========

to

==========
Disable scrollbar snapback on desktop Linux (Reland)

This CL disables scrollbar snapback to be more consistent with typical
desktop Linux UI.  Additionally, rename
webscrollbarbehavior_impl_gtkoraura* to
webscrollbarbehavior_impl_aura* since there's no longer a GTK backend
for Linux Chromium.

BUG=567968

Committed: https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f
Cr-Commit-Position: refs/heads/master@{#430994}
==========

[commit-bot: I haz the power, 2016-11-16 18:16:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-16 18:52:14]

Description was changed from

==========
Disable scrollbar snapback on desktop Linux (Reland)

This CL disables scrollbar snapback to be more consistent with typical
desktop Linux UI.  Additionally, rename
webscrollbarbehavior_impl_gtkoraura* to
webscrollbarbehavior_impl_aura* since there's no longer a GTK backend
for Linux Chromium.

BUG=567968

Committed: https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f
Cr-Commit-Position: refs/heads/master@{#430994}
==========

to

==========
Disable scrollbar snapback on desktop Linux (Reland)

This CL disables scrollbar snapback to be more consistent with typical
desktop Linux UI.  Additionally, rename
webscrollbarbehavior_impl_gtkoraura* to
webscrollbarbehavior_impl_aura* since there's no longer a GTK backend
for Linux Chromium.

BUG=567968

Committed: https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f
Committed: https://crrev.com/fd0d31facac27b29b5c60fc41f05fd4ca8486c6a
Cr-Original-Commit-Position: refs/heads/master@{#430994}
Cr-Commit-Position: refs/heads/master@{#432556}
==========

[commit-bot: I haz the power, 2016-11-16 18:52:15]

Patchset 4 (id:??) landed as
https://crrev.com/fd0d31facac27b29b5c60fc41f05fd4ca8486c6a
Cr-Commit-Position: refs/heads/master@{#432556}