Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2483103002: Remove NewJSObjectWithMemento (Closed)

Created:
4 years, 1 month ago by gsathya
Modified:
4 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove NewJSObjectWithMemento Seems unused. Committed: https://crrev.com/5329399ae21f61d4d2b520b6e88408fa987afbc1 Cr-Commit-Position: refs/heads/master@{#40843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M src/factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
gsathya
Hey Mike, adding you as R= as git blame tells me that you added this ...
4 years, 1 month ago (2016-11-08 03:26:59 UTC) #8
mvstanton
yep. LGTM, thanks!
4 years, 1 month ago (2016-11-08 12:55:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483103002/1
4 years, 1 month ago (2016-11-08 15:39:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 15:41:33 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:34 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5329399ae21f61d4d2b520b6e88408fa987afbc1
Cr-Commit-Position: refs/heads/master@{#40843}

Powered by Google App Engine
This is Rietveld 408576698