Remove Certificate Transparency information from WebsiteSettings

Remove Certificate Transparency information from WebsiteSettings

This information is too technical for laypeople, and is available in the
DevTools security people for developers and power users.

BUG=647947
Committed: https://crrev.com/cf30556b4a833e7b575c329c27f3262b4d15ff8c
Cr-Commit-Position: refs/heads/master@{#432079}

[estark, 2016-11-08 01:24:41]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 01:25:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-11-08 01:39:55]

Description was changed from

==========
Remove CT information from WebsiteSettings

BUG=
==========

to

==========
Remove CT information from WebsiteSettings

BUG=647947
==========

[commit-bot: I haz the power, 2016-11-08 02:07:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 02:07:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[estark, 2016-11-14 02:53:20]

Description was changed from

==========
Remove CT information from WebsiteSettings

BUG=647947
==========

to

==========
Remove Certificate Transparency information from WebsiteSettings

This information is too technical for laypeople, and is available in the
DevTools security people for developers and power users.

BUG=647947
==========

[estark, 2016-11-14 02:59:03]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 02:59:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 03:40:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 03:40:10]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[estark, 2016-11-14 04:55:37]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 04:55:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-11-14 04:56:35]

estark@chromium.org changed reviewers:
+ lgarron@chromium.org

[estark, 2016-11-14 04:56:35]

lgarron, PTAL?

[commit-bot: I haz the power, 2016-11-14 05:40:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 05:40:52]

Dry run: This issue passed the CQ dry run.

[lgarron, 2016-11-14 23:30:57]

lgtm

LGTM.

https://codereview.chromium.org/2483093002/diff/40001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2483093002/diff/40001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings.cc:421: bool is_ev =
!!(security_info.cert_status & net::CERT_STATUS_IS_EV);
Nit: Keep this inside the `else`, since it's only used there.

[estark, 2016-11-15 00:56:24]

https://codereview.chromium.org/2483093002/diff/40001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2483093002/diff/40001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings.cc:421: bool is_ev =
!!(security_info.cert_status & net::CERT_STATUS_IS_EV);
On 2016/11/14 23:30:57, lgarron wrote:
> Nit: Keep this inside the `else`, since it's only used there.

Done.

[estark, 2016-11-15 00:57:31]

The CQ bit was checked by estark@chromium.org

[estark, 2016-11-15 00:57:31]

The patchset sent to the CQ was uploaded after l-g-t-m from lgarron@chromium.org
Link to the patchset: https://codereview.chromium.org/2483093002/#ps60001
(title: "lgarron comment")

[commit-bot: I haz the power, 2016-11-15 00:58:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 03:46:20]

Description was changed from

==========
Remove Certificate Transparency information from WebsiteSettings

This information is too technical for laypeople, and is available in the
DevTools security people for developers and power users.

BUG=647947
==========

to

==========
Remove Certificate Transparency information from WebsiteSettings

This information is too technical for laypeople, and is available in the
DevTools security people for developers and power users.

BUG=647947
==========

[commit-bot: I haz the power, 2016-11-15 03:46:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-15 03:51:21]

Description was changed from

==========
Remove Certificate Transparency information from WebsiteSettings

This information is too technical for laypeople, and is available in the
DevTools security people for developers and power users.

BUG=647947
==========

to

==========
Remove Certificate Transparency information from WebsiteSettings

This information is too technical for laypeople, and is available in the
DevTools security people for developers and power users.

BUG=647947

Committed: https://crrev.com/cf30556b4a833e7b575c329c27f3262b4d15ff8c
Cr-Commit-Position: refs/heads/master@{#432079}
==========

[commit-bot: I haz the power, 2016-11-15 03:51:22]

Patchset 4 (id:??) landed as
https://crrev.com/cf30556b4a833e7b575c329c27f3262b4d15ff8c
Cr-Commit-Position: refs/heads/master@{#432079}