Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2483083002:
Fix leak in FocusManager tests (Closed)
|
Created:
4 years, 1 month ago by sky Modified:
4 years, 1 month ago Reviewers:
Ben Goodger (Google) CC:
chromium-reviews, tfarina Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix leak in FocusManager tests
They create a widget and never destroy it.
BUG=660994, 663418
TEST=test only change
R=ben@chromium.org
Committed: https://crrev.com/402f62030eda12d30ad6341e2774d9af2208bee1
Committed: https://crrev.com/e7886de9e860bac867bf6e029d8c6f2a0431a7b7
Cr-Original-Commit-Position: refs/heads/master@{#430457}
Cr-Commit-Position: refs/heads/master@{#430657}
Patch Set 1 #Patch Set 2 : merge to trunk #Patch Set 3 : ifdef for mac #Messages
Total messages: 21 (11 generated)
The CQ bit was checked by sky@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix leak in FocusManager tests They create a widget and never destroy it. BUG=660994 TEST=test only change R=ben@chromium.org ========== to ========== Fix leak in FocusManager tests They create a widget and never destroy it. BUG=660994 TEST=test only change R=ben@chromium.org Committed: https://crrev.com/402f62030eda12d30ad6341e2774d9af2208bee1 Cr-Commit-Position: refs/heads/master@{#430457} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/402f62030eda12d30ad6341e2774d9af2208bee1 Cr-Commit-Position: refs/heads/master@{#430457}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2484203002/ by henrika@chromium.org. The reason for reverting is: Following recommendation from Findit to revert for breaking: FocusTraversalTest.TraversalWithInvisibleViews FocusTraversalTest.NormalTraversalMac FocusTraversalTest.PaneTraversal FocusTraversalTest.FullKeyboardToggle FocusTraversalTest.TraversalWithNonEnabledViews See https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.c....
Message was sent while issue was closed.
Description was changed from ========== Fix leak in FocusManager tests They create a widget and never destroy it. BUG=660994 TEST=test only change R=ben@chromium.org Committed: https://crrev.com/402f62030eda12d30ad6341e2774d9af2208bee1 Cr-Commit-Position: refs/heads/master@{#430457} ========== to ========== Fix leak in FocusManager tests They create a widget and never destroy it. BUG=660994, 663418 TEST=test only change R=ben@chromium.org Committed: https://crrev.com/402f62030eda12d30ad6341e2774d9af2208bee1 Cr-Commit-Position: refs/heads/master@{#430457} ==========
This uncovered a bug in NativeWidgetMac/NativeViewHostMac. I'm ifdefing the code that tickles the bug and relanding.
The CQ bit was checked by sky@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org Link to the patchset: https://codereview.chromium.org/2483083002/#ps40001 (title: "ifdef for mac")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix leak in FocusManager tests They create a widget and never destroy it. BUG=660994, 663418 TEST=test only change R=ben@chromium.org Committed: https://crrev.com/402f62030eda12d30ad6341e2774d9af2208bee1 Cr-Commit-Position: refs/heads/master@{#430457} ========== to ========== Fix leak in FocusManager tests They create a widget and never destroy it. BUG=660994, 663418 TEST=test only change R=ben@chromium.org Committed: https://crrev.com/402f62030eda12d30ad6341e2774d9af2208bee1 Cr-Commit-Position: refs/heads/master@{#430457} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix leak in FocusManager tests They create a widget and never destroy it. BUG=660994, 663418 TEST=test only change R=ben@chromium.org Committed: https://crrev.com/402f62030eda12d30ad6341e2774d9af2208bee1 Cr-Commit-Position: refs/heads/master@{#430457} ========== to ========== Fix leak in FocusManager tests They create a widget and never destroy it. BUG=660994, 663418 TEST=test only change R=ben@chromium.org Committed: https://crrev.com/402f62030eda12d30ad6341e2774d9af2208bee1 Committed: https://crrev.com/e7886de9e860bac867bf6e029d8c6f2a0431a7b7 Cr-Original-Commit-Position: refs/heads/master@{#430457} Cr-Commit-Position: refs/heads/master@{#430657} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e7886de9e860bac867bf6e029d8c6f2a0431a7b7 Cr-Commit-Position: refs/heads/master@{#430657} |
