Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2483073002: Fix focus navigation for nested slot case (Closed)

Created:
4 years, 1 month ago by kochi
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix focus navigation for nested slot case For forward navigation, SlotScopedTraversal was not excluding an element that is assigned to another slot. For backward navigation, the original logic in FocusController/SlotScopedTraversal failed to detect case when shadow hosts exist in a slot scope. Elements that are slotted to slots in their shadow roots should be skipped in traversal. BUG=618587 Review-Url: https://codereview.chromium.org/2432293002 Cr-Commit-Position: refs/heads/master@{#428682} (cherry picked from commit 5639462246b2b792a1d75ba418fce6c6edd76940) Committed: https://chromium.googlesource.com/chromium/src/+/bcc1bf393bb93e080c224e743a9bb972948db27e

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
kochi
4 years, 1 month ago (2016-11-08 00:36:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bcc1bf393bb93e080c224e743a9bb972948db27e.

Powered by Google App Engine
This is Rietveld 408576698