Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2483033002: Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (Closed)

Created:
4 years, 1 month ago by ajuma
Modified:
4 years, 1 month ago
Reviewers:
jaydasika, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ ) Reason for revert: Possibly caused a regression in draw properties computation time (see http://crbug.com/663068). Original issue's description: > cc: Remove more references to owning_layer_ from RenderSurfaceImpl > > This removes more dependencies of RenderSurfaceImpl on its owning layer. > Specifically, this removes the use of owning_layer_ for accessing > property trees and debug colors, and for gettng the surface's > effect tree index. This also renames the OwningLayerId() method to id(). > > BUG=611883 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b > Cr-Commit-Position: refs/heads/master@{#428991} TBR=jaydasika@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=611883, 663068 Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade Cr-Commit-Position: refs/heads/master@{#430419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M cc/layers/render_surface_impl.h View 3 chunks +1 line, -5 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 9 chunks +19 lines, -14 lines 0 comments Download
M cc/trees/damage_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/draw_property_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
ajuma
Created Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl
4 years, 1 month ago (2016-11-07 21:46:48 UTC) #1
ajuma
4 years, 1 month ago (2016-11-07 21:47:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483033002/1
4 years, 1 month ago (2016-11-07 21:48:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 23:37:01 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade Cr-Commit-Position: refs/heads/master@{#430419}
4 years, 1 month ago (2016-11-07 23:43:42 UTC) #9
ajuma
4 years, 1 month ago (2016-11-21 18:35:52 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2517273002/ by ajuma@chromium.org.

The reason for reverting is: This turned out not to be the cause of the
regression in draw properties computation time..

Powered by Google App Engine
This is Rietveld 408576698