Mojo C++ bindings: Remove more use_new_wrapper_types=false.

Mojo C++ bindings: Remove more use_new_wrapper_types=false.

BUG=624136
Committed: https://crrev.com/49cfab6d30adf820c752e76c4dfe69a2137c2516
Cr-Commit-Position: refs/heads/master@{#430979}

[yzshen1, 2016-11-07 20:14:43]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 20:15:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-11-07 20:18:39]

yzshen@chromium.org changed reviewers:
+ blundell@chromium.org, sky@chromium.org

[yzshen1, 2016-11-07 20:18:40]

Hi, Scott and Colin.

Would you please take a look? Thanks!

Scott: chrome/*
Colin: components/*

[commit-bot: I haz the power, 2016-11-07 21:16:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 21:16:18]

Dry run: This issue passed the CQ dry run.

[sky, 2016-11-07 21:51:03]

LGTM

[blundell, 2016-11-08 08:32:41]

lgtm

https://codereview.chromium.org/2483013002/diff/1/components/safe_json/safe_j...
File components/safe_json/safe_json_parser_impl.cc (right):

https://codereview.chromium.org/2483013002/diff/1/components/safe_json/safe_j...
components/safe_json/safe_json_parser_impl.cc:77: error_message = *error;
tiny nit: I think it would be nicer to use |error.value()| here.

https://codereview.chromium.org/2483013002/diff/1/components/safe_json/utilit...
File components/safe_json/utility/safe_json_parser_mojo_impl.cc (right):

https://codereview.chromium.org/2483013002/diff/1/components/safe_json/utilit...
components/safe_json/utility/safe_json_parser_mojo_impl.cc:36:
callback.Run(wrapper, base::nullopt);
why this change?

[yzshen1, 2016-11-09 17:13:22]

Thanks!

https://codereview.chromium.org/2483013002/diff/1/components/safe_json/safe_j...
File components/safe_json/safe_json_parser_impl.cc (right):

https://codereview.chromium.org/2483013002/diff/1/components/safe_json/safe_j...
components/safe_json/safe_json_parser_impl.cc:77: error_message = *error;
On 2016/11/08 08:32:41, blundell wrote:
> tiny nit: I think it would be nicer to use |error.value()| here.

Done.

https://codereview.chromium.org/2483013002/diff/1/components/safe_json/utilit...
File components/safe_json/utility/safe_json_parser_mojo_impl.cc (right):

https://codereview.chromium.org/2483013002/diff/1/components/safe_json/utilit...
components/safe_json/utility/safe_json_parser_mojo_impl.cc:36:
callback.Run(wrapper, base::nullopt);
On 2016/11/08 08:32:41, blundell wrote:
> why this change?

Because the parameter type has changed from mojo::String to
base::Optional<std::string>.

The way to construct a null base::Optional<> is base::nullopt instead of
nullptr.

[yzshen1, 2016-11-09 17:16:35]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-11-09 17:16:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2483013002/#ps40001
(title: ".")

[yzshen1, 2016-11-09 17:16:50]

The CQ bit was unchecked by yzshen@chromium.org

[yzshen1, 2016-11-09 17:17:59]

Patchset #3 (id:40001) has been deleted

[yzshen1, 2016-11-09 17:18:03]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-11-09 17:18:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 18:12:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-09 18:18:31]

Description was changed from

==========
Mojo C++ bindings: Remove more use_new_wrapper_types=false.

BUG=624136
==========

to

==========
Mojo C++ bindings: Remove more use_new_wrapper_types=false.

BUG=624136

Committed: https://crrev.com/49cfab6d30adf820c752e76c4dfe69a2137c2516
Cr-Commit-Position: refs/heads/master@{#430979}
==========

[commit-bot: I haz the power, 2016-11-09 18:18:32]

Patchset 2 (id:??) landed as
https://crrev.com/49cfab6d30adf820c752e76c4dfe69a2137c2516
Cr-Commit-Position: refs/heads/master@{#430979}