Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2483003002: Sync pdfium tryserver list with main pdfium waterfall. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Sync pdfium tryserver list with main pdfium waterfall. BUG=pdfium:627 Committed: https://pdfium.googlesource.com/pdfium/+/2e969eaf1deca3e96725b7515afe3b4450ddc5fe

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Patch Set 3 : alphabetical order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M infra/config/cq.cfg View 1 2 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Lei Zhang
I think this requires https://codereview.chromium.org/2486463002/ I reordered the configs here as well.
4 years, 1 month ago (2016-11-07 19:55:44 UTC) #2
Wei Li
otherwise lgtm https://codereview.chromium.org/2483003002/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/2483003002/diff/1/infra/config/cq.cfg#newcode47 infra/config/cq.cfg:47: name: "linux_skia" I don't feel changing order ...
4 years, 1 month ago (2016-11-07 20:51:22 UTC) #3
Lei Zhang
https://codereview.chromium.org/2483003002/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/2483003002/diff/1/infra/config/cq.cfg#newcode47 infra/config/cq.cfg:47: name: "linux_skia" On 2016/11/07 20:51:22, Wei Li wrote: > ...
4 years, 1 month ago (2016-11-07 21:24:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483003002/40001
4 years, 1 month ago (2016-11-07 23:02:09 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 23:04:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/2e969eaf1deca3e96725b7515afe3b4450dd...

Powered by Google App Engine
This is Rietveld 408576698