MediaSettingsRange: s/long/double/ in MediaSettingsRange.idl and PhotoCapabilities.idl

MediaSettingsRange: s/long/double/ in MediaSettingsRange.idl and PhotoCapabilities.idl

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages
floats).

The change is rippled down to the mojom and
the implementations.  In Android:
- Reading capabilities and status are changed to
using double.
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed.

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
Committed: https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3
Cr-Commit-Position: refs/heads/master@{#431293}

[mcasas, 2016-11-09 00:52:05]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-11-09 00:52:11]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-11-09 00:52:16]

Patchset #1 (id:40001) has been deleted

[mcasas, 2016-11-09 00:52:23]

Patchset #1 (id:60001) has been deleted

[mcasas, 2016-11-09 02:04:55]

Description was changed from

==========
MediaSettingsRange: s/long/double/

BUG=663021
==========

to

==========
MediaSettingsRange: s/long/double/


For the Android implementations, this only affects
the zoom and exposure compensations, the other
settings/controls are untouched.
 
BUG=663021
==========

[mcasas, 2016-11-09 03:41:17]

Description was changed from

==========
MediaSettingsRange: s/long/double/


For the Android implementations, this only affects
the zoom and exposure compensations, the other
settings/controls are untouched.
 
BUG=663021
==========

to

==========
MediaSettingsRange: s/long/double/

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings.
The change is rippled down to the mojom and 
the implementations. 

In particular, for the Android implementations, 
zoom and exposure compensation don't need to 
have  x100 multipliers, so these are removed. 
Floats are used for reading (double being 
unnecessary).  Settings use doubles and those are 
treated internally as such or as integer as the API 
requires.
 
[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
==========

[mcasas, 2016-11-09 17:00:44]

Patchset #1 (id:80001) has been deleted

[mcasas, 2016-11-09 17:06:12]

Patchset #1 (id:100001) has been deleted

[mcasas, 2016-11-09 17:56:03]

Description was changed from

==========
MediaSettingsRange: s/long/double/

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings.
The change is rippled down to the mojom and 
the implementations. 

In particular, for the Android implementations, 
zoom and exposure compensation don't need to 
have  x100 multipliers, so these are removed. 
Floats are used for reading (double being 
unnecessary).  Settings use doubles and those are 
treated internally as such or as integer as the API 
requires.
 
[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
==========

to

==========
MediaSettingsRange: s/long/double/

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages 
floats).

The change is rippled down to the mojom and 
the implementations.  In Android:
- Reading capabilities and status are changed to
using floats (double being unnecessary precision).
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed. 

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
==========

[mcasas, 2016-11-09 17:56:19]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2016-11-09 17:56:19]

reillyg@ PTAL

[mcasas, 2016-11-09 17:56:45]

Description was changed from

==========
MediaSettingsRange: s/long/double/

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages 
floats).

The change is rippled down to the mojom and 
the implementations.  In Android:
- Reading capabilities and status are changed to
using floats (double being unnecessary precision).
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed. 

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
==========

to

==========
MediaSettingsRange: s/long/double/ in MediaSettingsRange.idl and
PhotoCapabilities.idl

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages 
floats).

The change is rippled down to the mojom and 
the implementations.  In Android:
- Reading capabilities and status are changed to
using floats (double being unnecessary precision).
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed. 

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
==========

[Reilly Grant (use Gerrit), 2016-11-09 21:16:55]

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
File
media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java
(right):

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java:27:
public final float maxZoom;
I think we should just use double everywhere.

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
(right):

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:368:
// The Max zoom is returned as x100 by the API to avoid using floating point.
Comment is out of date.

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
File media/capture/video/android/video_capture_device_android.cc (right):

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
media/capture/video/android/video_capture_device_android.cc:601: const double
iso = settings->has_iso ? settings->iso : 0;
While you're changing this around can you make some consistency between whether
or not these properties are declared as local variables before being passed to
setPhotoOptions?

[mcasas, 2016-11-09 22:41:55]

Description was changed from

==========
MediaSettingsRange: s/long/double/ in MediaSettingsRange.idl and
PhotoCapabilities.idl

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages 
floats).

The change is rippled down to the mojom and 
the implementations.  In Android:
- Reading capabilities and status are changed to
using floats (double being unnecessary precision).
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed. 

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
==========

to

==========
MediaSettingsRange: s/long/double/ in MediaSettingsRange.idl and
PhotoCapabilities.idl

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages 
floats).

The change is rippled down to the mojom and 
the implementations.  In Android:
- Reading capabilities and status are changed to
using double.
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed. 

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
==========

[mcasas, 2016-11-09 22:44:13]

mcasas@chromium.org changed reviewers:
+ tsepez@chromium.org

[mcasas, 2016-11-09 22:44:14]

reillyg@ comments addressed, ptal

tsepez@ RS the s/uint32/double/ change in the .mojom, thx

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
File
media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java
(right):

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java:27:
public final float maxZoom;
On 2016/11/09 21:16:55, Reilly Grant wrote:
> I think we should just use double everywhere.

Done.

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
(right):

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:368:
// The Max zoom is returned as x100 by the API to avoid using floating point.
On 2016/11/09 21:16:55, Reilly Grant wrote:
> Comment is out of date.

Oops done, thanks.

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
File media/capture/video/android/video_capture_device_android.cc (right):

https://codereview.chromium.org/2482983002/diff/120001/media/capture/video/an...
media/capture/video/android/video_capture_device_android.cc:601: const double
iso = settings->has_iso ? settings->iso : 0;
On 2016/11/09 21:16:55, Reilly Grant wrote:
> While you're changing this around can you make some consistency between
whether
> or not these properties are declared as local variables before being passed to
> setPhotoOptions?

Done. I also moved |width| and |height| assignment
after|exposure_mode| so that the initialization order 
replicates the usage.

[mcasas, 2016-11-09 23:33:33]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 23:34:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2016-11-10 01:00:07]

lgtm

https://codereview.chromium.org/2482983002/diff/140001/media/capture/video/fa...
File media/capture/video/fake_video_capture_device.cc (right):

https://codereview.chromium.org/2482983002/diff/140001/media/capture/video/fa...
media/capture/video/fake_video_capture_device.cc:88: float zoom) {
s/float/double/

https://codereview.chromium.org/2482983002/diff/140001/media/capture/video/fa...
File media/capture/video/fake_video_capture_device.h (right):

https://codereview.chromium.org/2482983002/diff/140001/media/capture/video/fa...
media/capture/video/fake_video_capture_device.h:72: float current_zoom_;
s/float/double/

[commit-bot: I haz the power, 2016-11-10 03:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 03:15:34]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mcasas, 2016-11-10 06:25:04]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 06:25:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-11-10 06:26:30]

https://codereview.chromium.org/2482983002/diff/140001/media/capture/video/fa...
File media/capture/video/fake_video_capture_device.cc (right):

https://codereview.chromium.org/2482983002/diff/140001/media/capture/video/fa...
media/capture/video/fake_video_capture_device.cc:88: float zoom) {
On 2016/11/10 01:00:07, Reilly Grant wrote:
> s/float/double/

Done.

https://codereview.chromium.org/2482983002/diff/140001/media/capture/video/fa...
File media/capture/video/fake_video_capture_device.h (right):

https://codereview.chromium.org/2482983002/diff/140001/media/capture/video/fa...
media/capture/video/fake_video_capture_device.h:72: float current_zoom_;
On 2016/11/10 01:00:07, Reilly Grant wrote:
> s/float/double/

Done.

[commit-bot: I haz the power, 2016-11-10 07:56:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 07:56:15]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-10 16:51:46]

RS LGTM

[mcasas, 2016-11-10 18:11:46]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-11-10 18:11:46]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2482983002/#ps150001
(title: "s/float/double/ in fake_video_capture_device.*")

[commit-bot: I haz the power, 2016-11-10 18:12:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 18:17:51]

Description was changed from

==========
MediaSettingsRange: s/long/double/ in MediaSettingsRange.idl and
PhotoCapabilities.idl

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages 
floats).

The change is rippled down to the mojom and 
the implementations.  In Android:
- Reading capabilities and status are changed to
using double.
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed. 

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
==========

to

==========
MediaSettingsRange: s/long/double/ in MediaSettingsRange.idl and
PhotoCapabilities.idl

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages 
floats).

The change is rippled down to the mojom and 
the implementations.  In Android:
- Reading capabilities and status are changed to
using double.
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed. 

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
==========

[commit-bot: I haz the power, 2016-11-10 18:17:53]

Committed patchset #3 (id:150001)

[commit-bot: I haz the power, 2016-11-10 18:38:43]

Description was changed from

==========
MediaSettingsRange: s/long/double/ in MediaSettingsRange.idl and
PhotoCapabilities.idl

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages 
floats).

The change is rippled down to the mojom and 
the implementations.  In Android:
- Reading capabilities and status are changed to
using double.
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed. 

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021
==========

to

==========
MediaSettingsRange: s/long/double/ in MediaSettingsRange.idl and
PhotoCapabilities.idl

This CL follows issue [1] in replacing integer
types with doubles in the capabilities/settings idl
(WebIdl encourages doubles and discourages
floats).

The change is rippled down to the mojom and
the implementations.  In Android:
- Reading capabilities and status are changed to
using double.
- Configuring settings are changed to use doubles.
- zoom and exposure compensation setting/reading
don't need to have x100 multipliers anymore, removed.

Otherwise:
- v4l2_capture_delegate.cc bugfix: unnecessary scaling
of zoom during setting (unmatched on retrieving).
- FakeVideoCaptureDevice changes to doubles.

[1] https://github.com/w3c/mediacapture-image/issues/77
BUG=663021

Committed: https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3
Cr-Commit-Position: refs/heads/master@{#431293}
==========

[commit-bot: I haz the power, 2016-11-10 18:38:44]

Patchset 3 (id:??) landed as
https://crrev.com/5a4284b492c9511bd41ccad6e53f339a6de409a3
Cr-Commit-Position: refs/heads/master@{#431293}