Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2482933002: Revert of Don't apply maximized window bounds workaround if bounds aren't changed (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
atimoxin
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't apply maximized window bounds workaround if bounds aren't changed (patchset #1 id:1 of https://codereview.chromium.org/2454053004/ ) Reason for revert: This resulted in a shortcut to move between monitors not working. See 656001. Original issue's description: > Don't apply maximized window bounds workaround if bounds aren't changed > > In HWNDMessageHandler::OnWindowPosChanging() was added code that > restores correct maximized window's bounds after attaching or detaching > additional display (see crrev.com/6bb7f8192). But this workaround also > applied if OnWindowPosChanging() was called with SWP_NOMOVE/SWP_NOSIZE > flags that leads to bugs such as crbug.com/659525 and crbug.com/655984. > > This CL adds additional check for SWP_NOMOVE/SWP_NOSIZE flags before > applying workaround and fixes this bugs. > > BUG=659525, 655984 > > Committed: https://crrev.com/6279588b7ebc740f85409107dd91b5c3ce628065 > Cr-Commit-Position: refs/heads/master@{#428368} TBR=atimoxin@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659525, 655984 Committed: https://crrev.com/deb38c53aaeb0ca533daf90abe4f46536df1661b Cr-Commit-Position: refs/heads/master@{#430314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
Created Revert of Don't apply maximized window bounds workaround if bounds aren't changed
4 years, 1 month ago (2016-11-07 17:17:37 UTC) #2
sky
It's actually https://codereview.chromium.org/2379063003 that caused the regression, but as this patch built on https://codereview.chromium.org/2379063003 I'm ...
4 years, 1 month ago (2016-11-07 17:18:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482933002/1
4 years, 1 month ago (2016-11-07 17:18:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 18:07:14 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 18:14:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/deb38c53aaeb0ca533daf90abe4f46536df1661b
Cr-Commit-Position: refs/heads/master@{#430314}

Powered by Google App Engine
This is Rietveld 408576698