Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: src/ic/handler-compiler.h

Issue 2482913002: [ic] Resurrect access checks for primitive and global proxy receivers. (Closed)
Patch Set: Check with enabled data handlers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ic/handler-compiler.h
diff --git a/src/ic/handler-compiler.h b/src/ic/handler-compiler.h
index 1023fafdec8e27d05f27965732a6d4c5dbd178b2..b844ce025866611041a060e2014fbc6eaf9227c2 100644
--- a/src/ic/handler-compiler.h
+++ b/src/ic/handler-compiler.h
@@ -83,6 +83,18 @@ class PropertyHandlerCompiler : public PropertyAccessCompiler {
Handle<Name> name, Register scratch,
Label* miss);
+ // Generates check that current native context has the same access rights
+ // than given |native_context_cell|.
Jakob Kummerow 2016/11/08 10:56:53 nit: s/than/as the/
Igor Sheludko 2016/11/08 12:07:55 Done.
+ // If |compare_native_contexts_only| is true then access check is considered
+ // passed if the execution-time native context is equal to contents of
+ // |native_context_cell|.
+ // If |compare_native_contexts_only| is false then access check is considered
+ // passed if the execution-time native context is equal to contents of
+ // |native_context_cell| or security tokens of both contexts are equal.
+ void GenerateAccessCheck(Handle<WeakCell> native_context_cell,
+ Register scratch1, Register scratch2, Label* miss,
+ bool compare_native_contexts_only);
+
// Generates code that verifies that the property holder has not changed
// (checking maps of objects in the prototype chain for fast and global
// objects or doing negative lookup for slow objects, ensures that the

Powered by Google App Engine
This is Rietveld 408576698