Add is_srcdoc to FrameNavigationEntry and restore about::srcdoc URL.

content/browser/frame_host/frame_navigation_entry.h

Index: content/browser/frame_host/frame_navigation_entry.h
diff --git a/content/browser/frame_host/frame_navigation_entry.h b/content/browser/frame_host/frame_navigation_entry.h
index eca2712e788460b4eed86682a92671bf4521949e..a2d76668deefcc3499687554a60342aecb9d2362 100644
--- a/content/browser/frame_host/frame_navigation_entry.h
+++ b/content/browser/frame_host/frame_navigation_entry.h
@@ -39,7 +39,8 @@ class CONTENT_EXPORT FrameNavigationEntry
                        const GURL& url,
                        const Referrer& referrer,
                        const std::string& method,
-                       int64_t post_id);
+                       int64_t post_id,
+                       bool is_srcdoc);
 
   // Creates a copy of this FrameNavigationEntry that can be modified
   // independently from the original.
@@ -56,7 +57,8 @@ class CONTENT_EXPORT FrameNavigationEntry
                    const std::vector<GURL>& redirect_chain,
                    const PageState& page_state,
                    const std::string& method,
-                   int64_t post_id);
+                   int64_t post_id,
+                   bool is_srcdoc);
 
   // The unique name of the frame this entry is for.  This is a stable name for
   // the frame based on its position in the tree and relation to other named
@@ -134,6 +136,9 @@ class CONTENT_EXPORT FrameNavigationEntry
   // is not a POST.
   scoped_refptr<ResourceRequestBodyImpl> GetPostData() const;
 
+  // Whether the navigation is for an iframe with srcdoc attribute

[Charlie Reis, 2016/11/07 21:32:58]

nit: End with period.

[arthursonzogni, 2016/11/08 12:21:30]

Done.

+  bool is_srcdoc() const { return is_srcdoc_; }
+
  private:
   friend class base::RefCounted<FrameNavigationEntry>;
   virtual ~FrameNavigationEntry();
@@ -162,6 +167,7 @@ class CONTENT_EXPORT FrameNavigationEntry
   PageState page_state_;
   std::string method_;
   int64_t post_id_;
+  bool is_srcdoc_;

[Charlie Reis, 2016/11/07 21:32:58]

Does this value get restored properly if you quit and restart, restoring all
your tabs?  It's not persisted directly, but it does look like you might be able
to recover from that in RecursivelyGenerateFrameEntries.

[arthursonzogni, 2016/11/08 12:21:30]

Yes, is_srcdoc is restored properly because of the three lines I added in
RecursivelyGenerateFrameEntries.

But if these lines weren't there, there wouldn't be any problems for the user
either. |is_srcdoc| would be false instead of true and the |url| would be
about::srcdoc instead of about::blank in the browser. Finally the renderer would
see about::srcdoc as it is supposed to do.

 
   DISALLOW_COPY_AND_ASSIGN(FrameNavigationEntry);
 };