Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2482863004: Check negative overflow of quickSkFDot6Div (Closed)

Created:
4 years, 1 month ago by liyuqian
Modified:
4 years, 1 month ago
Reviewers:
f(malita), caryclark, reed1
CC:
reviews_skia.org, mtklein_C, benjaminwagner_chromium.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Check negative overflow of quickSkFDot6Div The following fuzz html reveals the bug in chromium content_shell ===html=begins=== <style> *{min-width:4%;-webkit-border-radius:+256%;} .CLASS11{text-decoration:rgba(128%,16129%,1%,0.0000000004656612317904879831274006762300773920593144339363789186) dotted blink;vertical-align:124px;-webkit-column-count:2147483655 !important;</style> <h1 class="CLASS11 CLASS1"> > B <button> <h4 class="CLASS11 CLASS12"> </h4> <p> c C <table> <caption class="CLASS11"> > <ruby class="CLASS11 CLASS12"> </ruby> AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA x ===html===ends=== BUG=chromium:662905 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482863004 Committed: https://skia.googlesource.com/skia/+/671ce62f35049808378ee966da0e7b3acd0be30a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/core/SkAnalyticEdge.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
liyuqian
4 years, 1 month ago (2016-11-08 22:22:28 UTC) #4
caryclark
lgtm
4 years, 1 month ago (2016-11-09 12:29:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482863004/1
4 years, 1 month ago (2016-11-09 14:57:57 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 15:24:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/671ce62f35049808378ee966da0e7b3acd0be30a

Powered by Google App Engine
This is Rietveld 408576698