Add Memory.Coordinator.FreeMemoryUntilCritical UMA

Add Memory.Coordinator.FreeMemoryUntilCritical UMA

Report free memory until the system enters critical state.

Design doc: https://docs.google.com/document/d/1Mlx7q_8thkoQtg_C7-CNA_y0SxSK0yp_ja9Zs4HmcwU/edit#heading=h.92zih6k89h8i

BUG=662772
Committed: https://crrev.com/d3bec15af939d0841149aa0f24e1816e586dd47a
Cr-Commit-Position: refs/heads/master@{#431160}

[bashi, 2016-11-08 04:24:44]

bashi@chromium.org changed reviewers:
+ chrisha@chromium.org, haraken@chromium.org

[bashi, 2016-11-08 04:24:45]

PTAL.

I'll wait for https://codereview.chromium.org/2479673002/ is landed. I think
this UMA should be recorded when we set |remaining_global_budget|.

[haraken, 2016-11-08 05:09:59]

LGTM

[chrisha, 2016-11-09 21:42:51]

lgtm

https://codereview.chromium.org/2482863003/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator_impl.cc (right):

https://codereview.chromium.org/2482863003/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator_impl.cc:161:
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Coordinator.FreeMemoryUntilCritical",
Assign this TODO(chrisha) to me, and I can take care of moving it at the same
time as that other CL?

[bashi, 2016-11-09 23:57:47]

bashi@chromium.org changed reviewers:
+ holte@chromium.org

[bashi, 2016-11-09 23:57:48]

holte@: Could you review histograms.xml?

https://codereview.chromium.org/2482863003/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator_impl.cc (right):

https://codereview.chromium.org/2482863003/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator_impl.cc:161:
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Coordinator.FreeMemoryUntilCritical",
On 2016/11/09 21:42:51, chrisha (slow) wrote:
> Assign this TODO(chrisha) to me, and I can take care of moving it at the same
> time as that other CL?

Done. Thanks for taking over this :)

[haraken, 2016-11-10 01:45:34]

On 2016/11/09 23:57:48, bashi1 wrote:
> holte@: Could you review histograms.xml?

(BTW, I'm an owner of histrograms.xml.)

[bashi, 2016-11-10 01:57:37]

On 2016/11/10 01:45:34, haraken wrote:
> On 2016/11/09 23:57:48, bashi1 wrote:
> > holte@: Could you review histograms.xml?
> 
> (BTW, I'm an owner of histrograms.xml.)

The comment in OWNERS says you review for UseCounter histogram changes only. Are
these kind of metrics also UserCounter histogram? That's good to know :)

[Steven Holte, 2016-11-10 02:07:14]

lgtm

[bashi, 2016-11-10 02:09:21]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 02:09:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 02:57:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 02:57:38]

Dry run: This issue passed the CQ dry run.

[bashi, 2016-11-10 03:09:03]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-11-10 03:09:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/2482863003/#ps20001
(title: "Assign TODO to chrisha@")

[commit-bot: I haz the power, 2016-11-10 03:09:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 03:15:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-10 03:19:26]

Description was changed from

==========
Add Memory.Coordinator.FreeMemoryUntilCritical UMA

Report free memory until the system enters critical state.

Design doc:
https://docs.google.com/document/d/1Mlx7q_8thkoQtg_C7-CNA_y0SxSK0yp_ja9Zs4Hmc...

BUG=662772
==========

to

==========
Add Memory.Coordinator.FreeMemoryUntilCritical UMA

Report free memory until the system enters critical state.

Design doc:
https://docs.google.com/document/d/1Mlx7q_8thkoQtg_C7-CNA_y0SxSK0yp_ja9Zs4Hmc...

BUG=662772

Committed: https://crrev.com/d3bec15af939d0841149aa0f24e1816e586dd47a
Cr-Commit-Position: refs/heads/master@{#431160}
==========

[commit-bot: I haz the power, 2016-11-10 03:19:30]

Patchset 2 (id:??) landed as
https://crrev.com/d3bec15af939d0841149aa0f24e1816e586dd47a
Cr-Commit-Position: refs/heads/master@{#431160}