Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: content/browser/renderer_host/render_widget_host_unittest.cc

Issue 2482853002: Suppress KeyUp events after PreHandleKeyboardEvent consumes RawKeyDown (Closed)
Patch Set: andt typo Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_unittest.cc b/content/browser/renderer_host/render_widget_host_unittest.cc
index ad51e3a71573f50e2e0a48f61af38dd4d1c4d25d..2dc9a62d5580d804481b4469696f9ed55829ef6a 100644
--- a/content/browser/renderer_host/render_widget_host_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_unittest.cc
@@ -966,18 +966,23 @@ TEST_F(RenderWidgetHostTest, PreHandleRawKeyDownEvent) {
// Forward the KeyUp event.
SimulateKeyboardEvent(WebInputEvent::KeyUp);
- // Make sure only KeyUp was sent to the renderer.
+ // Make sure the KeyUp event is suppressed.
+ EXPECT_EQ(0U, process_->sink().message_count());
+
+ // Simulate a new RawKeyDown event.
+ SimulateKeyboardEvent(WebInputEvent::RawKeyDown);
EXPECT_EQ(1U, process_->sink().message_count());
EXPECT_EQ(InputMsg_HandleInputEvent::ID,
process_->sink().GetMessageAt(0)->type());
process_->sink().ClearMessages();
// Send the simulated response from the renderer back.
- SendInputEventACK(WebInputEvent::KeyUp,
+ SendInputEventACK(WebInputEvent::RawKeyDown,
INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
EXPECT_TRUE(delegate_->unhandled_keyboard_event_called());
- EXPECT_EQ(WebInputEvent::KeyUp, delegate_->unhandled_keyboard_event_type());
+ EXPECT_EQ(WebInputEvent::RawKeyDown,
+ delegate_->unhandled_keyboard_event_type());
}
TEST_F(RenderWidgetHostTest, RawKeyDownShortcutEvent) {

Powered by Google App Engine
This is Rietveld 408576698