Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2482853002: Suppress KeyUp events after PreHandleKeyboardEvent consumes RawKeyDown (Closed)
Patch Set: andt typo Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_aura.h" 5 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
6 6
7 #include <set> 7 #include <set>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 1709 matching lines...) Expand 10 before | Expand all | Expand 10 after
1720 host_->GotFocus(); 1720 host_->GotFocus();
1721 host_->SetActive(true); 1721 host_->SetActive(true);
1722 1722
1723 ui::InputMethod* input_method = GetInputMethod(); 1723 ui::InputMethod* input_method = GetInputMethod();
1724 if (input_method) { 1724 if (input_method) {
1725 // Ask the system-wide IME to send all TextInputClient messages to |this| 1725 // Ask the system-wide IME to send all TextInputClient messages to |this|
1726 // object. 1726 // object.
1727 input_method->SetFocusedTextInputClient(this); 1727 input_method->SetFocusedTextInputClient(this);
1728 1728
1729 // Often the application can set focus to the view in response to a key 1729 // Often the application can set focus to the view in response to a key
1730 // down. However the following char event shouldn't be sent to the web 1730 // down. However, the following events shouldn't be sent to the web page.
1731 // page. 1731 host_->SuppressEventsUntilKeyDown();
1732 host_->SuppressNextCharEvents();
1733 } 1732 }
1734 1733
1735 BrowserAccessibilityManager* manager = 1734 BrowserAccessibilityManager* manager =
1736 host_->GetRootBrowserAccessibilityManager(); 1735 host_->GetRootBrowserAccessibilityManager();
1737 if (manager) 1736 if (manager)
1738 manager->OnWindowFocused(); 1737 manager->OnWindowFocused();
1739 } else if (window_ == lost_focus) { 1738 } else if (window_ == lost_focus) {
1740 host_->SetActive(false); 1739 host_->SetActive(false);
1741 host_->Blur(); 1740 host_->Blur();
1742 1741
(...skipping 637 matching lines...) Expand 10 before | Expand all | Expand 10 after
2380 2379
2381 void RenderWidgetHostViewAura::SetPopupChild( 2380 void RenderWidgetHostViewAura::SetPopupChild(
2382 RenderWidgetHostViewAura* popup_child_host_view) { 2381 RenderWidgetHostViewAura* popup_child_host_view) {
2383 popup_child_host_view_ = popup_child_host_view; 2382 popup_child_host_view_ = popup_child_host_view;
2384 event_handler_->SetPopupChild( 2383 event_handler_->SetPopupChild(
2385 popup_child_host_view, 2384 popup_child_host_view,
2386 popup_child_host_view ? popup_child_host_view->event_handler() : nullptr); 2385 popup_child_host_view ? popup_child_host_view->event_handler() : nullptr);
2387 } 2386 }
2388 2387
2389 } // namespace content 2388 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698