Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Issue 2482803003: Revert of [ObjC ARC] Converts crw_web_controller to ARC. (Closed)

Created:
4 years, 1 month ago by baxley
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts crw_web_controller to ARC. (patchset #8 id:140001 of https://codereview.chromium.org/2434853002/ ) Reason for revert: This caused multiple Chrome for iOS unit tests to fail when creating tabs. It resulted in tests crashing when checking if currently on the web thread. Original issue's description: > [ObjC ARC] Converts crw_web_controller to ARC. > > Notable changes: > * crw_web_controller.mm used to have a dictionary storing selectors just > for keeping the KVO code clean. ARC cannot call a selector from a string > like this, because it cannot guarantee correct memory management in > this case. So it was replaced with an array of observed key paths to > keep some of the code cleanness, while the KVO callback has a huge > switch. > > BUG=624365 > TEST=None > > Committed: https://crrev.com/9b6f44b09855a803914efd9877fddb471a97cbf1 > Cr-Commit-Position: refs/heads/master@{#430304} TBR=sdefresne@chromium.org,eugenebut@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624365 Committed: https://crrev.com/85d802e4f2fc5ee1c7480f8f99e83455035f65c8 Cr-Commit-Position: refs/heads/master@{#430443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -105 lines) Patch
M ios/web/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 38 chunks +119 lines, -94 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
baxley
Created Revert of [ObjC ARC] Converts crw_web_controller to ARC.
4 years, 1 month ago (2016-11-08 00:33:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482803003/1
4 years, 1 month ago (2016-11-08 00:34:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 00:37:13 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/85d802e4f2fc5ee1c7480f8f99e83455035f65c8 Cr-Commit-Position: refs/heads/master@{#430443}
4 years, 1 month ago (2016-11-08 00:52:46 UTC) #7
sdefresne
lgtm
4 years, 1 month ago (2016-11-08 08:41:41 UTC) #8
stkhapugin
4 years, 1 month ago (2016-11-08 14:25:57 UTC) #9
Message was sent while issue was closed.
On 2016/11/08 08:41:41, sdefresne wrote:
> lgtm

lgtm. In the future when creating a revert, please include at least one example
failure log.

Powered by Google App Engine
This is Rietveld 408576698