Chromium Code Reviews
DescriptionRevert of [ObjC ARC] Converts crw_web_controller to ARC. (patchset #8 id:140001 of https://codereview.chromium.org/2434853002/ )
Reason for revert:
This caused multiple Chrome for iOS unit tests to fail when creating tabs.
It resulted in tests crashing when checking if currently on the web thread.
Original issue's description:
> [ObjC ARC] Converts crw_web_controller to ARC.
>
> Notable changes:
> * crw_web_controller.mm used to have a dictionary storing selectors just
> for keeping the KVO code clean. ARC cannot call a selector from a string
> like this, because it cannot guarantee correct memory management in
> this case. So it was replaced with an array of observed key paths to
> keep some of the code cleanness, while the KVO callback has a huge
> switch.
>
> BUG=624365
> TEST=None
>
> Committed: https://crrev.com/9b6f44b09855a803914efd9877fddb471a97cbf1
> Cr-Commit-Position: refs/heads/master@{#430304}
TBR=sdefresne@chromium.org,eugenebut@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624365
Committed: https://crrev.com/85d802e4f2fc5ee1c7480f8f99e83455035f65c8
Cr-Commit-Position: refs/heads/master@{#430443}
Patch Set 1 #
Messages
Total messages: 9 (3 generated)
|
|||||||||||||||||||||||||||||||||||||