third_party/WebKit/LayoutTests/animations/zoom-responsive-transform-animation.html - Issue 2482753002: Fix matrix3d transform under page zoom

Side by Side Diff: third_party/WebKit/LayoutTests/animations/zoom-responsive-transform-animation.html

Issue 2482753002: Fix matrix3d transform under page zoom (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« AUTHORS ('K') | « AUTHORS ('k') | third_party/WebKit/LayoutTests/animations/zoom-responsive-transform-animation-expected.html » ('j') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <style>	2 <style>

3 #container {	3 #container {

4 position: absolute;	4 position: absolute;

5 top: 0;	5 top: 0;

6 font-size: 10px;	6 font-size: 10px;

7 }	7 }

8 .target {	8 .target {

9 width: 40px;	9 width: 40px;

10 height: 40px;	10 height: 40px;

11 border-top: solid;	11 border-top: solid;

12 border-left: solid;	12 border-left: solid;

13 margin-bottom: 20px;	13 margin-bottom: 20px;

14 }	14 }

15 </style>	15 </style>

16 <div id="container"></div>	16 <div id="container"></div>

17 <script>	17 <script>

18 [	18 [

19 'perspective(200px) translate3D(10px, 10px, 10px)',	19 'perspective(200px) translate3D(10px, 10px, 10px)',
	pdr. 2016/11/08 07:04:08 Instead of modifying these tests, can you add new Instead of modifying these tests, can you add new ones (possibly unit tests like TransformOperationsTest.cpp)? This makes it easier to check how existing tests do/don't change. Franklin Ta 2016/11/08 07:52:18 Acknowledged. Show quoted text On 2016/11/08 07:04:08, pdr. wrote: > Instead of modifying these tests, can you add new ones (possibly unit tests like > TransformOperationsTest.cpp)? This makes it easier to check how existing tests > do/don't change. Acknowledged. Franklin Ta 2016/11/09 07:12:06 Done. Show quoted text On 2016/11/08 07:52:18, Franklin Ta wrote: > On 2016/11/08 07:04:08, pdr. wrote: > > Instead of modifying these tests, can you add new ones (possibly unit tests > like > > TransformOperationsTest.cpp)? This makes it easier to check how existing tests > > do/don't change. > > Acknowledged. Done.
20 'matrix(0, 1, 1, 0, 10, 10)',	20 'matrix(0, 1, 1, 0, 10, 10)',

21 'matrix3d(' +	21 'matrix3d(' +

22 '0, 1, 0, 0, ' +	22 '0.707106781186548, 0.000000000000000, -0.707106781186547, 0.003535533905933 ,' +

23 '1, 0, 0, 0, ' +	23 '0.000000000000000, 1.000000000000000, 0.000000000000000, 0.000000000000000, ' +

24 '0, 0, 1, 0, ' +	24 '0.707106781186547, 0.000000000000000, 0.707106781186548, -0.003535533905933 ,' +

25 '10, 10, 10, 1)',	25 '0.000000000000000, 0.000000000000000, 0.000000000000000, 1.000000000000000) ',

26 'perspective(200px) rotateY(45deg)',	26 'perspective(200px) rotateY(45deg)',

27 'none',	27 'none',

28 ].forEach(transform => {	28 ].forEach(transform => {

29 var text = document.createElement('div');	29 var text = document.createElement('div');

30 text.textContent = transform;	30 text.textContent = transform;

31 container.appendChild(text);	31 container.appendChild(text);

32	32

33 var target = document.createElement('div');	33 var target = document.createElement('div');

34 target.classList.add('target');	34 target.classList.add('target');

35 container.appendChild(target);	35 container.appendChild(target);

36 target.animate([	36 target.animate([

37 {transform: transform},	37 {transform: transform},

38 {transform: transform},	38 {transform: transform},

39 ], 1e8);	39 ], 1e8);

40 });	40 });

41	41

42 if (window.testRunner)	42 if (window.testRunner)

43 testRunner.waitUntilDone();	43 testRunner.waitUntilDone();

44	44

45 requestAnimationFrame(() => {	45 requestAnimationFrame(() => {

46 requestAnimationFrame(() => {	46 requestAnimationFrame(() => {

47 internals.setZoomFactor(2);	47 internals.setZoomFactor(2);

48 requestAnimationFrame(() => {	48 requestAnimationFrame(() => {

49 if (window.testRunner)	49 if (window.testRunner)

50 testRunner.notifyDone();	50 testRunner.notifyDone();

51 });	51 });

52 });	52 });

53 });	53 });

54 </script>	54 </script>

OLD	NEW