Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2482743002: [GeometryInterface] add toJson() function in DOMMatrixReadOnly. (Closed)

Created:
4 years, 1 month ago by Hwanseung Lee
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GeometryInterface] add toJson() function in DOMMatrixReadOnly. Return the result of jsonObject which has all attributes. spec list: https://drafts.fxtf.org/geometry/#dommatrixreadonly BUG=388780, 660830 Committed: https://crrev.com/febb9b528f9b0605b8b6d1423eaa62de3431daa8 Cr-Commit-Position: refs/heads/master@{#430549}

Patch Set 1 #

Patch Set 2 : [GeometryInterface] add toJson() function. #

Patch Set 3 : add test for DOMMatrix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp View 1 2 chunks +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
Hwanseung Lee
@dominicc, zino PTAL, thank you.
4 years, 1 month ago (2016-11-06 09:29:16 UTC) #3
zino
Please add tests for DOMMatrix.toJSON(). Because DOMMatrix inherits from DOMMatrixReadOnly.
4 years, 1 month ago (2016-11-06 13:32:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482743002/40001
4 years, 1 month ago (2016-11-07 12:55:10 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-07 12:55:12 UTC) #12
Hwanseung Lee
On 2016/11/06 13:32:21, zino wrote: > Please add tests for DOMMatrix.toJSON(). > Because DOMMatrix inherits ...
4 years, 1 month ago (2016-11-07 12:55:50 UTC) #13
zino
lgtm
4 years, 1 month ago (2016-11-07 14:16:19 UTC) #14
dominicc (has gone to gerrit)
lgtm
4 years, 1 month ago (2016-11-08 08:37:58 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482743002/40001
4 years, 1 month ago (2016-11-08 08:38:16 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-08 08:44:01 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 08:45:54 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/febb9b528f9b0605b8b6d1423eaa62de3431daa8
Cr-Commit-Position: refs/heads/master@{#430549}

Powered by Google App Engine
This is Rietveld 408576698