Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2482713002: [ios] Removes an unneeded UIWindow from HardwareKeyboardWatcherTest. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
gchatz
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removes an unneeded UIWindow from HardwareKeyboardWatcherTest. This test created a UIWindow and set it as the key window, which seemed to tickle an iOS9 bug that left the application without a key window at all once the test finished. This was causing subsequent tests to fail. The test passes without this UIWindow, so this CL removes it. BUG=None Committed: https://crrev.com/72df1e67aea177a06a6cf539b2eeadeb517a4a58 Cr-Commit-Position: refs/heads/master@{#430177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher_unittest.mm View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
gchatz
On 2016/11/06 00:59:21, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 1 month ago (2016-11-06 01:07:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482713002/1
4 years, 1 month ago (2016-11-06 01:08:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-06 03:48:58 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-06 03:53:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72df1e67aea177a06a6cf539b2eeadeb517a4a58
Cr-Commit-Position: refs/heads/master@{#430177}

Powered by Google App Engine
This is Rietveld 408576698