Use perfect forwarding in createT of SkSmallAllocator.

Use perfect forwarding in createT of SkSmallAllocator.

This allows createT statements to be written in a clearer style.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482683002

Committed: https://skia.googlesource.com/skia/+/ad512797c9405f78b080a1d24cd98f465b9879dd

[herb_g, 2016-11-06 00:02:01]

Description was changed from

==========
Use perfect forwarding in createT of SkSmallAllocator.

This allows createT statements to be written in a clearer style.
BUG=skia:
==========

to

==========
Use perfect forwarding in createT of SkSmallAllocator.

This allows createT statements to be written in a clearer style.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482683002
==========

[herb_g, 2016-11-06 00:03:01]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-06 00:03:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[herb_g, 2016-11-06 00:18:25]

Description was changed from

==========
Use perfect forwarding in createT of SkSmallAllocator.

This allows createT statements to be written in a clearer style.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482683002
==========

to

==========
Use perfect forwarding in createT of SkSmallAllocator.

This allows createT statements to be written in a clearer style.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482683002
==========

[herb_g, 2016-11-06 00:18:25]

herb@google.com changed reviewers:
+ mtklein@google.com

[commit-bot: I haz the power, 2016-11-06 00:24:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 00:24:54]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2016-11-06 13:25:15]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-11-06 13:25:16]

lgtm

https://codereview.chromium.org/2482683002/diff/1/src/core/SkSmallAllocator.h
File src/core/SkSmallAllocator.h (left):

https://codereview.chromium.org/2482683002/diff/1/src/core/SkSmallAllocator.h...
src/core/SkSmallAllocator.h:37: {}
Seems unnecessary?

https://codereview.chromium.org/2482683002/diff/1/src/core/SkSmallAllocator.h
File src/core/SkSmallAllocator.h (right):

https://codereview.chromium.org/2482683002/diff/1/src/core/SkSmallAllocator.h...
src/core/SkSmallAllocator.h:14: #include <new>
Probably a good idea to include <utility>

https://codereview.chromium.org/2482683002/diff/1/src/core/SkSmallAllocator.h...
src/core/SkSmallAllocator.h:118: static constexpr size_t kAlignment = 16UL;
Unused?

[herb_g, 2016-11-07 04:43:01]

Edits

[herb_g, 2016-11-07 04:44:40]

https://codereview.chromium.org/2482683002/diff/1/src/core/SkSmallAllocator.h
File src/core/SkSmallAllocator.h (left):

https://codereview.chromium.org/2482683002/diff/1/src/core/SkSmallAllocator.h...
src/core/SkSmallAllocator.h:37: {}
On 2016/11/06 13:25:16, mtklein_C wrote:
> Seems unnecessary?

Done.

https://codereview.chromium.org/2482683002/diff/1/src/core/SkSmallAllocator.h
File src/core/SkSmallAllocator.h (right):

https://codereview.chromium.org/2482683002/diff/1/src/core/SkSmallAllocator.h...
src/core/SkSmallAllocator.h:14: #include <new>
On 2016/11/06 13:25:16, mtklein_C wrote:
> Probably a good idea to include <utility>

Done.

https://codereview.chromium.org/2482683002/diff/1/src/core/SkSmallAllocator.h...
src/core/SkSmallAllocator.h:118: static constexpr size_t kAlignment = 16UL;
On 2016/11/06 13:25:16, mtklein_C wrote:
> Unused?

Done.

[herb_g, 2016-11-07 04:44:53]

The CQ bit was checked by herb@google.com

[herb_g, 2016-11-07 04:44:53]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@chromium.org
Link to the patchset: https://codereview.chromium.org/2482683002/#ps20001
(title: "Edits")

[commit-bot: I haz the power, 2016-11-07 04:44:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 05:07:04]

Description was changed from

==========
Use perfect forwarding in createT of SkSmallAllocator.

This allows createT statements to be written in a clearer style.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482683002
==========

to

==========
Use perfect forwarding in createT of SkSmallAllocator.

This allows createT statements to be written in a clearer style.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482683002

Committed:
https://skia.googlesource.com/skia/+/ad512797c9405f78b080a1d24cd98f465b9879dd
==========

[commit-bot: I haz the power, 2016-11-07 05:07:04]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ad512797c9405f78b080a1d24cd98f465b9879dd