Issue 2482663002: Clean up fx_codec_icc.cpp

Issue 2482663002: Clean up fx_codec_icc.cpp (Closed)

Created:
4 years, 1 month ago by kcwu

Modified:
4 years, 1 month ago

Reviewers:
dsinclair

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

More Reviews

Description

Clean up fx_codec_icc.cpp Committed: https://pdfium.googlesource.com/pdfium/+/a94fc11866adb1b9ca4a4e1afb4fb574ed472e07

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -29 lines)			Patch
	M	core/fxcodec/codec/fx_codec_icc.cpp	View		3 chunks	+1 line, -29 lines	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482663002/1

4 years, 1 month ago (2016-11-07 14:29:13 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/a94fc11866adb1b9ca4a4e1afb4fb574ed472e07

4 years, 1 month ago (2016-11-07 16:42:01 UTC) #7

kcwu

4 years, 1 month ago (2016-11-09 03:56:55 UTC) #8

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2485363002/ by kcwu@chromium.org.

The reason for reverting is: Max cmsChannelsOf() is 15, which is larger than
expectation of existing code and cause crashes (at least the fuzzer).

BUG=chromium:663240.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages