Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2482653002: Move MIME related platform files under network/mime (Closed)

Created:
4 years, 1 month ago by kinuko
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews, esprehn, Takashi Toyoshima
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MIME related platform files under network/mime * MIMETypeRegistry.cpp * MIMETypeFromURL.{cpp,h} * ContentType.{cpp,h} Follow-up for crrev.com/2444873002 BUG=659467 Committed: https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58 Cr-Commit-Position: refs/heads/master@{#436977}

Patch Set 1 : #

Patch Set 2 : more #

Patch Set 3 : rebase #

Patch Set 4 : fix #

Total comments: 8

Patch Set 5 : fix #

Patch Set 6 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -385 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMImplementation.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/platform/ContentType.h View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/platform/ContentType.cpp View 1 2 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/Source/platform/MIMETypeFromURL.h View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/platform/MIMETypeFromURL.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/platform/MIMETypeRegistry.h View 1 2 1 chunk +0 lines, -107 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-encoders/ImageEncoderUtils.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/network/mime/ContentType.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/network/mime/ContentType.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/network/mime/MIMETypeFromURL.h View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/network/mime/MIMETypeFromURL.cpp View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.h View 1 2 3 4 5 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/mime/MIMETypeRegistryTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 52 (42 generated)
kinuko
Moving all the remaining mime files. Mechanical changes only-- PTL!
4 years, 1 month ago (2016-11-06 07:11:52 UTC) #9
kinuko
Friendly ping-- this is not too exciting change but could you review? (or please kindly ...
4 years, 1 month ago (2016-11-11 13:42:26 UTC) #10
kinuko
Mike, do you think you can review this? The change itself is pretty mechanical, new ...
4 years ago (2016-12-04 15:39:01 UTC) #31
Mike West
LGTM, except for the license changes. If you're just moving the file, my understanding is ...
4 years ago (2016-12-06 13:44:35 UTC) #32
tyoshino (SeeGerritForStatus)
On 2016/12/06 13:44:35, Mike West (slow) wrote: > LGTM, except for the license changes. If ...
4 years ago (2016-12-07 07:20:11 UTC) #33
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/2482653002/diff/130001/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp (left): https://codereview.chromium.org/2482653002/diff/130001/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp#oldcode62 third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp:62: #include "core/loader/resource/CSSStyleSheetResource.h" toCSSStyleSheetResource() used in this file is ...
4 years ago (2016-12-07 07:20:20 UTC) #35
kinuko
Thanks! Restored the copyright info in the moved files. https://codereview.chromium.org/2482653002/diff/130001/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp (left): https://codereview.chromium.org/2482653002/diff/130001/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp#oldcode62 third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp:62: ...
4 years ago (2016-12-07 15:33:36 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482653002/170001
4 years ago (2016-12-07 15:34:07 UTC) #47
commit-bot: I haz the power
Committed patchset #6 (id:170001)
4 years ago (2016-12-07 16:36:17 UTC) #50
commit-bot: I haz the power
4 years ago (2016-12-07 16:39:15 UTC) #52
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58
Cr-Commit-Position: refs/heads/master@{#436977}

Powered by Google App Engine
This is Rietveld 408576698