Roll tools/swarming_client 380e3266..ebc8dab6

Roll src/tools/swarming_client/ 380e32662..ebc8dab6f (25 commits).

https://chromium.googlesource.com/external/swarming.client.git/+log/380e32662312..ebc8dab6f8b8

$ git log 380e32662..ebc8dab6f --date=short --no-merges --format='%ad %ae %s'
2016-11-01 dnj Update LogDog client library to generate URLs.
2016-11-01 bpastene Roll infra_libs to 564aaf7480f24c90687df79d9cef910cc342a54d
2016-10-31 aludwin Don't recreate a directory if it already exists
2016-10-31 vadimsh Fix how --auth-disabled works, in particular on headless bots.
2016-10-28 iannucci Fix secret-bytes-path flag to use dashes instead of underscores.
2016-10-28 iannucci Add secret_bytes functionality to swarming.
2016-10-28 aludwin Add --output option to Swarming client and pass it through to the bot
2016-10-27 aludwin Return specific files, not just those in $(ISOLATED_OUTDIR)
2016-10-27 maruel Update stale links to code.google.com.
2016-10-27 iannucci Fix auth_server_test.py
2016-10-26 nodir swarming: implement named caches
2016-10-26 nodir run_isolated: fix --leak-temp-dir
2016-10-26 aludwin Pass args in file from task_runner to run_isolated
2016-10-20 iannucci Alter bot code to use new LUCI_CONTEXT library.
2016-10-19 nodir run_isolated: rename cache to isolate_cache
2016-10-19 iannucci Add luci_context library.
2016-10-18 nodir LRUDict: add timestamps
2016-10-13 leilei Fix encode issue.
2016-10-12 nodir run_isolated: rename cache to isolate_cache
2016-10-12 smut Don't assume existence of dimensions when querying for Swarming bots
2016-09-14 ryanmartens Adds LUCI context auth service access token.
2016-09-13 vadimsh Add --service-account option to 'trigger' and 'run'.
2016-09-12 ryanmartens Adds auth option `luci_context_json`.
2016-09-09 vadimsh Implement local HTTP server that serves task OAuth access tokens.
2016-09-07 ryanmartens Refactors authentictors into separate file.

BUG=659291
R=maruel@chromium.org,dnj@chromium.org

Committed: https://crrev.com/bc0614e467b9538c2930b93a5c058c8b66c93cac
Cr-Commit-Position: refs/heads/master@{#431365}

[jbudorick, 2016-11-05 03:17:50]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 03:18:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 03:25:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 03:25:39]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbudorick, 2016-11-08 20:46:32]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 20:47:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 20:56:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 20:56:47]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbudorick, 2016-11-08 22:06:41]

jbudorick@chromium.org changed reviewers:
+ dnj@chromium.org, maruel@chromium.org

[M-A Ruel, 2016-11-08 23:10:30]

Can you use roll-dep src/tools/swarming_client ? It gives a nice list of the
changes being incorporated.

[jbudorick, 2016-11-09 18:43:17]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 18:43:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2016-11-09 18:45:00]

Description was changed from

==========
Roll tools/swarming_client 380e3266..ebc8dab6

https://chromium.googlesource.com/external/swarming.client.git/+log/380e3266....

BUG=659291
==========

to

==========
Roll src/tools/swarming_client/ 380e32662..ebc8dab6f (25 commits).

https://chromium.googlesource.com/external/swarming.client.git/+log/380e32662...

$ git log 380e32662..ebc8dab6f --date=short --no-merges --format='%ad %ae %s'
2016-11-01 dnj Update LogDog client library to generate URLs.
2016-11-01 bpastene Roll infra_libs to 564aaf7480f24c90687df79d9cef910cc342a54d
2016-10-31 aludwin Don't recreate a directory if it already exists
2016-10-31 vadimsh Fix how --auth-disabled works, in particular on headless
bots.
2016-10-28 iannucci Fix secret-bytes-path flag to use dashes instead of
underscores.
2016-10-28 iannucci Add secret_bytes functionality to swarming.
2016-10-28 aludwin Add --output option to Swarming client and pass it through to
the bot
2016-10-27 aludwin Return specific files, not just those in $(ISOLATED_OUTDIR)
2016-10-27 maruel Update stale links to code.google.com.
2016-10-27 iannucci Fix auth_server_test.py
2016-10-26 nodir swarming: implement named caches
2016-10-26 nodir run_isolated: fix --leak-temp-dir
2016-10-26 aludwin Pass args in file from task_runner to run_isolated
2016-10-20 iannucci Alter bot code to use new LUCI_CONTEXT library.
2016-10-19 nodir run_isolated: rename cache to isolate_cache
2016-10-19 iannucci Add luci_context library.
2016-10-18 nodir LRUDict: add timestamps
2016-10-13 leilei Fix encode issue.
2016-10-12 nodir run_isolated: rename cache to isolate_cache
2016-10-12 smut Don't assume existence of dimensions when querying for Swarming
bots
2016-09-14 ryanmartens Adds LUCI context auth service access token.
2016-09-13 vadimsh Add --service-account option to 'trigger' and 'run'.
2016-09-12 ryanmartens Adds auth option `luci_context_json`.
2016-09-09 vadimsh Implement local HTTP server that serves task OAuth access
tokens.
2016-09-07 ryanmartens Refactors authentictors into separate file.

BUG=659291
R=maruel@chromium.org,dnj@chromium.org
==========

[jbudorick, 2016-11-09 18:45:15]

On 2016/11/08 23:10:30, M-A Ruel wrote:
> Can you use roll-dep src/tools/swarming_client ? It gives a nice list of the
> changes being incorporated.

Done.

[commit-bot: I haz the power, 2016-11-09 18:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 18:52:14]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[M-A Ruel, 2016-11-09 21:19:11]

Description was changed from

==========
Roll src/tools/swarming_client/ 380e32662..ebc8dab6f (25 commits).

https://chromium.googlesource.com/external/swarming.client.git/+log/380e32662...

$ git log 380e32662..ebc8dab6f --date=short --no-merges --format='%ad %ae %s'
2016-11-01 dnj Update LogDog client library to generate URLs.
2016-11-01 bpastene Roll infra_libs to 564aaf7480f24c90687df79d9cef910cc342a54d
2016-10-31 aludwin Don't recreate a directory if it already exists
2016-10-31 vadimsh Fix how --auth-disabled works, in particular on headless
bots.
2016-10-28 iannucci Fix secret-bytes-path flag to use dashes instead of
underscores.
2016-10-28 iannucci Add secret_bytes functionality to swarming.
2016-10-28 aludwin Add --output option to Swarming client and pass it through to
the bot
2016-10-27 aludwin Return specific files, not just those in $(ISOLATED_OUTDIR)
2016-10-27 maruel Update stale links to code.google.com.
2016-10-27 iannucci Fix auth_server_test.py
2016-10-26 nodir swarming: implement named caches
2016-10-26 nodir run_isolated: fix --leak-temp-dir
2016-10-26 aludwin Pass args in file from task_runner to run_isolated
2016-10-20 iannucci Alter bot code to use new LUCI_CONTEXT library.
2016-10-19 nodir run_isolated: rename cache to isolate_cache
2016-10-19 iannucci Add luci_context library.
2016-10-18 nodir LRUDict: add timestamps
2016-10-13 leilei Fix encode issue.
2016-10-12 nodir run_isolated: rename cache to isolate_cache
2016-10-12 smut Don't assume existence of dimensions when querying for Swarming
bots
2016-09-14 ryanmartens Adds LUCI context auth service access token.
2016-09-13 vadimsh Add --service-account option to 'trigger' and 'run'.
2016-09-12 ryanmartens Adds auth option `luci_context_json`.
2016-09-09 vadimsh Implement local HTTP server that serves task OAuth access
tokens.
2016-09-07 ryanmartens Refactors authentictors into separate file.

BUG=659291
R=maruel@chromium.org,dnj@chromium.org
==========

to

==========
Roll src/tools/swarming_client/ 380e32662..ebc8dab6f (25 commits).

https://chromium.googlesource.com/external/swarming.client.git/+log/380e32662...

$ git log 380e32662..ebc8dab6f --date=short --no-merges --format='%ad %ae %s'
2016-11-01 dnj Update LogDog client library to generate URLs.
2016-11-01 bpastene Roll infra_libs to 564aaf7480f24c90687df79d9cef910cc342a54d
2016-10-31 aludwin Don't recreate a directory if it already exists
2016-10-31 vadimsh Fix how --auth-disabled works, in particular on headless
bots.
2016-10-28 iannucci Fix secret-bytes-path flag to use dashes instead of
underscores.
2016-10-28 iannucci Add secret_bytes functionality to swarming.
2016-10-28 aludwin Add --output option to Swarming client and pass it through to
the bot
2016-10-27 aludwin Return specific files, not just those in $(ISOLATED_OUTDIR)
2016-10-27 maruel Update stale links to code.google.com.
2016-10-27 iannucci Fix auth_server_test.py
2016-10-26 nodir swarming: implement named caches
2016-10-26 nodir run_isolated: fix --leak-temp-dir
2016-10-26 aludwin Pass args in file from task_runner to run_isolated
2016-10-20 iannucci Alter bot code to use new LUCI_CONTEXT library.
2016-10-19 nodir run_isolated: rename cache to isolate_cache
2016-10-19 iannucci Add luci_context library.
2016-10-18 nodir LRUDict: add timestamps
2016-10-13 leilei Fix encode issue.
2016-10-12 nodir run_isolated: rename cache to isolate_cache
2016-10-12 smut Don't assume existence of dimensions when querying for Swarming
bots
2016-09-14 ryanmartens Adds LUCI context auth service access token.
2016-09-13 vadimsh Add --service-account option to 'trigger' and 'run'.
2016-09-12 ryanmartens Adds auth option `luci_context_json`.
2016-09-09 vadimsh Implement local HTTP server that serves task OAuth access
tokens.
2016-09-07 ryanmartens Refactors authentictors into separate file.

BUG=659291
R=maruel@chromium.org,dnj@chromium.org
==========

[M-A Ruel, 2016-11-09 21:19:11]

maruel@chromium.org changed reviewers:
+ iannucci@chromium.org

[M-A Ruel, 2016-11-09 21:19:25]

On 2016/11/09 18:45:15, jbudorick wrote:
> On 2016/11/08 23:10:30, M-A Ruel wrote:
> > Can you use roll-dep src/tools/swarming_client ? It gives a nice list of the
> > changes being incorporated.
> 
> Done.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux...
(...)
  File "tools/swarming_client/utils/oauth.py", line 44, in <module>
    from libs import luci_context

Robbie?

[iannucci, 2016-11-10 00:00:07]

On 2016/11/09 21:19:25, M-A Ruel wrote:
> On 2016/11/09 18:45:15, jbudorick wrote:
> > On 2016/11/08 23:10:30, M-A Ruel wrote:
> > > Can you use roll-dep src/tools/swarming_client ? It gives a nice list of
the
> > > changes being incorporated.
> > 
> > Done.
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux...
> (...)
>   File "tools/swarming_client/utils/oauth.py", line 44, in <module>
>     from libs import luci_context
> 
> Robbie?

I'm not sure what the question is? Yes those files are needed... I thought I
added them to the list in luci-py already?

[iannucci, 2016-11-10 00:02:34]

On 2016/11/10 00:00:07, iannucci wrote:
> On 2016/11/09 21:19:25, M-A Ruel wrote:
> > On 2016/11/09 18:45:15, jbudorick wrote:
> > > On 2016/11/08 23:10:30, M-A Ruel wrote:
> > > > Can you use roll-dep src/tools/swarming_client ? It gives a nice list of
> the
> > > > changes being incorporated.
> > > 
> > > Done.
> > 
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux...
> > (...)
> >   File "tools/swarming_client/utils/oauth.py", line 44, in <module>
> >     from libs import luci_context
> > 
> > Robbie?
> 
> I'm not sure what the question is? Yes those files are needed... I thought I
> added them to the list in luci-py already?

https://github.com/luci/luci-py/blob/master/appengine/swarming/server/bot_arc...

[M-A Ruel, 2016-11-10 00:42:11]

maruel@chromium.org changed reviewers:
+ agrieve@chromium.org
- iannucci@chromium.org

[M-A Ruel, 2016-11-10 00:43:49]

On 2016/11/10 00:02:34, iannucci wrote:
> On 2016/11/10 00:00:07, iannucci wrote:
> > On 2016/11/09 21:19:25, M-A Ruel wrote:
> > > On 2016/11/09 18:45:15, jbudorick wrote:
> > > > On 2016/11/08 23:10:30, M-A Ruel wrote:
> > > > > Can you use roll-dep src/tools/swarming_client ? It gives a nice list
of
> > the
> > > > > changes being incorporated.
> > > > 
> > > > Done.
> > > 
> > >
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux...
> > > (...)
> > >   File "tools/swarming_client/utils/oauth.py", line 44, in <module>
> > >     from libs import luci_context
> > > 
> > > Robbie?
> > 
> > I'm not sure what the question is? Yes those files are needed... I thought I
> > added them to the list in luci-py already?
> 
>
https://github.com/luci/luci-py/blob/master/appengine/swarming/server/bot_arc...

Andrew,

Running:
build/print_python_deps.py --root tools/swarming_client --output
build/secondary/tools/swarming_client/isolate.pydeps --whitelist
tools/swarming_client/libs --whitelist tools/swarming_client/third_party
tools/swarming_client/isolate.py --output ""

works locally with tools/swarming_client synced at ToT but it failed on the
presubmit builder. Any idea?

[jbudorick, 2016-11-10 00:53:20]

On 2016/11/10 00:43:49, M-A Ruel wrote:
> On 2016/11/10 00:02:34, iannucci wrote:
> > On 2016/11/10 00:00:07, iannucci wrote:
> > > On 2016/11/09 21:19:25, M-A Ruel wrote:
> > > > On 2016/11/09 18:45:15, jbudorick wrote:
> > > > > On 2016/11/08 23:10:30, M-A Ruel wrote:
> > > > > > Can you use roll-dep src/tools/swarming_client ? It gives a nice
list
> of
> > > the
> > > > > > changes being incorporated.
> > > > > 
> > > > > Done.
> > > > 
> > > >
> > >
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux...
> > > > (...)
> > > >   File "tools/swarming_client/utils/oauth.py", line 44, in <module>
> > > >     from libs import luci_context
> > > > 
> > > > Robbie?
> > > 
> > > I'm not sure what the question is? Yes those files are needed... I thought
I
> > > added them to the list in luci-py already?
> > 
> >
>
https://github.com/luci/luci-py/blob/master/appengine/swarming/server/bot_arc...
> 
> Andrew,
> 
> Running:
> build/print_python_deps.py --root tools/swarming_client --output
> build/secondary/tools/swarming_client/isolate.pydeps --whitelist
> tools/swarming_client/libs --whitelist tools/swarming_client/third_party
> tools/swarming_client/isolate.py --output ""
> 
> works locally with tools/swarming_client synced at ToT but it failed on the
> presubmit builder. Any idea?

I wonder if it's resolving "libs" to something else on the PYTHONPATH?

[M-A Ruel, 2016-11-10 01:03:36]

On 2016/11/10 00:53:20, jbudorick wrote:
> On 2016/11/10 00:43:49, M-A Ruel wrote:
> > Andrew,
> > 
> > Running:
> > build/print_python_deps.py --root tools/swarming_client --output
> > build/secondary/tools/swarming_client/isolate.pydeps --whitelist
> > tools/swarming_client/libs --whitelist tools/swarming_client/third_party
> > tools/swarming_client/isolate.py --output ""
> > 
> > works locally with tools/swarming_client synced at ToT but it failed on the
> > presubmit builder. Any idea?
> 
> I wonder if it's resolving "libs" to something else on the PYTHONPATH?

It is fairly probable, likely to infra/infra/libs...  dang.

[iannucci, 2016-11-10 18:37:37]

On 2016/11/10 01:03:36, M-A Ruel wrote:
> On 2016/11/10 00:53:20, jbudorick wrote:
> > On 2016/11/10 00:43:49, M-A Ruel wrote:
> > > Andrew,
> > > 
> > > Running:
> > > build/print_python_deps.py --root tools/swarming_client --output
> > > build/secondary/tools/swarming_client/isolate.pydeps --whitelist
> > > tools/swarming_client/libs --whitelist tools/swarming_client/third_party
> > > tools/swarming_client/isolate.py --output ""
> > > 
> > > works locally with tools/swarming_client synced at ToT but it failed on
the
> > > presubmit builder. Any idea?
> > 
> > I wonder if it's resolving "libs" to something else on the PYTHONPATH?
> 
> It is fairly probable, likely to infra/infra/libs...  dang.

arg :(. python whyyyy :(

I'm not sure what to do?

[agrieve, 2016-11-10 19:21:45]

On 2016/11/10 18:37:37, iannucci wrote:
> On 2016/11/10 01:03:36, M-A Ruel wrote:
> > On 2016/11/10 00:53:20, jbudorick wrote:
> > > On 2016/11/10 00:43:49, M-A Ruel wrote:
> > > > Andrew,
> > > > 
> > > > Running:
> > > > build/print_python_deps.py --root tools/swarming_client --output
> > > > build/secondary/tools/swarming_client/isolate.pydeps --whitelist
> > > > tools/swarming_client/libs --whitelist tools/swarming_client/third_party
> > > > tools/swarming_client/isolate.py --output ""
> > > > 
> > > > works locally with tools/swarming_client synced at ToT but it failed on
> the
> > > > presubmit builder. Any idea?
> > > 
> > > I wonder if it's resolving "libs" to something else on the PYTHONPATH?
> > 
> > It is fairly probable, likely to infra/infra/libs...  dang.
> 
> arg :(. python whyyyy :(
> 
> I'm not sure what to do?

I *think* you can change the import to:
    from .libs import foo  
(prefix with a dot)

[jbudorick, 2016-11-10 19:23:24]

On 2016/11/10 19:21:45, agrieve wrote:
> On 2016/11/10 18:37:37, iannucci wrote:
> > On 2016/11/10 01:03:36, M-A Ruel wrote:
> > > On 2016/11/10 00:53:20, jbudorick wrote:
> > > > On 2016/11/10 00:43:49, M-A Ruel wrote:
> > > > > Andrew,
> > > > > 
> > > > > Running:
> > > > > build/print_python_deps.py --root tools/swarming_client --output
> > > > > build/secondary/tools/swarming_client/isolate.pydeps --whitelist
> > > > > tools/swarming_client/libs --whitelist
tools/swarming_client/third_party
> > > > > tools/swarming_client/isolate.py --output ""
> > > > > 
> > > > > works locally with tools/swarming_client synced at ToT but it failed
on
> > the
> > > > > presubmit builder. Any idea?
> > > > 
> > > > I wonder if it's resolving "libs" to something else on the PYTHONPATH?
> > > 
> > > It is fairly probable, likely to infra/infra/libs...  dang.
> > 
> > arg :(. python whyyyy :(
> > 
> > I'm not sure what to do?
> 
> I *think* you can change the import to:
>     from .libs import foo  
> (prefix with a dot)

I was considering mangling the sys.path in build/print_python_deps.py to ensure
we don't have errant directories in there.

[agrieve, 2016-11-10 19:35:53]

On 2016/11/10 19:23:24, jbudorick wrote:
> On 2016/11/10 19:21:45, agrieve wrote:
> > On 2016/11/10 18:37:37, iannucci wrote:
> > > On 2016/11/10 01:03:36, M-A Ruel wrote:
> > > > On 2016/11/10 00:53:20, jbudorick wrote:
> > > > > On 2016/11/10 00:43:49, M-A Ruel wrote:
> > > > > > Andrew,
> > > > > > 
> > > > > > Running:
> > > > > > build/print_python_deps.py --root tools/swarming_client --output
> > > > > > build/secondary/tools/swarming_client/isolate.pydeps --whitelist
> > > > > > tools/swarming_client/libs --whitelist
> tools/swarming_client/third_party
> > > > > > tools/swarming_client/isolate.py --output ""
> > > > > > 
> > > > > > works locally with tools/swarming_client synced at ToT but it failed
> on
> > > the
> > > > > > presubmit builder. Any idea?
> > > > > 
> > > > > I wonder if it's resolving "libs" to something else on the PYTHONPATH?
> > > > 
> > > > It is fairly probable, likely to infra/infra/libs...  dang.
> > > 
> > > arg :(. python whyyyy :(
> > > 
> > > I'm not sure what to do?
> > 
> > I *think* you can change the import to:
> >     from .libs import foo  
> > (prefix with a dot)
> 
> I was considering mangling the sys.path in build/print_python_deps.py to
ensure
> we don't have errant directories in there.

Oh! That's it! The script was appending to sys.path rather than clobbering the
first entry. Fix is here:
https://codereview.chromium.org/2489393002

[agrieve, 2016-11-10 20:04:30]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[agrieve, 2016-11-10 20:04:54]

On 2016/11/10 19:35:53, agrieve wrote:
> On 2016/11/10 19:23:24, jbudorick wrote:
> > On 2016/11/10 19:21:45, agrieve wrote:
> > > On 2016/11/10 18:37:37, iannucci wrote:
> > > > On 2016/11/10 01:03:36, M-A Ruel wrote:
> > > > > On 2016/11/10 00:53:20, jbudorick wrote:
> > > > > > On 2016/11/10 00:43:49, M-A Ruel wrote:
> > > > > > > Andrew,
> > > > > > > 
> > > > > > > Running:
> > > > > > > build/print_python_deps.py --root tools/swarming_client --output
> > > > > > > build/secondary/tools/swarming_client/isolate.pydeps --whitelist
> > > > > > > tools/swarming_client/libs --whitelist
> > tools/swarming_client/third_party
> > > > > > > tools/swarming_client/isolate.py --output ""
> > > > > > > 
> > > > > > > works locally with tools/swarming_client synced at ToT but it
failed
> > on
> > > > the
> > > > > > > presubmit builder. Any idea?
> > > > > > 
> > > > > > I wonder if it's resolving "libs" to something else on the
PYTHONPATH?
> > > > > 
> > > > > It is fairly probable, likely to infra/infra/libs...  dang.
> > > > 
> > > > arg :(. python whyyyy :(
> > > > 
> > > > I'm not sure what to do?
> > > 
> > > I *think* you can change the import to:
> > >     from .libs import foo  
> > > (prefix with a dot)
> > 
> > I was considering mangling the sys.path in build/print_python_deps.py to
> ensure
> > we don't have errant directories in there.
> 
> Oh! That's it! The script was appending to sys.path rather than clobbering the
> first entry. Fix is here:
> https://codereview.chromium.org/2489393002

fix landed, so clicked the dry-run button on this CL to see if it's fixed.

[commit-bot: I haz the power, 2016-11-10 20:04:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2016-11-10 20:45:07]

On 2016/11/10 20:04:54, agrieve wrote:
> On 2016/11/10 19:35:53, agrieve wrote:
> > On 2016/11/10 19:23:24, jbudorick wrote:
> > > On 2016/11/10 19:21:45, agrieve wrote:
> > > > On 2016/11/10 18:37:37, iannucci wrote:
> > > > > On 2016/11/10 01:03:36, M-A Ruel wrote:
> > > > > > On 2016/11/10 00:53:20, jbudorick wrote:
> > > > > > > On 2016/11/10 00:43:49, M-A Ruel wrote:
> > > > > > > > Andrew,
> > > > > > > > 
> > > > > > > > Running:
> > > > > > > > build/print_python_deps.py --root tools/swarming_client --output
> > > > > > > > build/secondary/tools/swarming_client/isolate.pydeps --whitelist
> > > > > > > > tools/swarming_client/libs --whitelist
> > > tools/swarming_client/third_party
> > > > > > > > tools/swarming_client/isolate.py --output ""
> > > > > > > > 
> > > > > > > > works locally with tools/swarming_client synced at ToT but it
> failed
> > > on
> > > > > the
> > > > > > > > presubmit builder. Any idea?
> > > > > > > 
> > > > > > > I wonder if it's resolving "libs" to something else on the
> PYTHONPATH?
> > > > > > 
> > > > > > It is fairly probable, likely to infra/infra/libs...  dang.
> > > > > 
> > > > > arg :(. python whyyyy :(
> > > > > 
> > > > > I'm not sure what to do?
> > > > 
> > > > I *think* you can change the import to:
> > > >     from .libs import foo  
> > > > (prefix with a dot)
> > > 
> > > I was considering mangling the sys.path in build/print_python_deps.py to
> > ensure
> > > we don't have errant directories in there.
> > 
> > Oh! That's it! The script was appending to sys.path rather than clobbering
the
> > first entry. Fix is here:
> > https://codereview.chromium.org/2489393002
> 
> fix landed, so clicked the dry-run button on this CL to see if it's fixed.

This now clears presubmit. Thanks for the fix, Andrew!

[commit-bot: I haz the power, 2016-11-10 21:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:06:06]

Dry run: This issue passed the CQ dry run.

[M-A Ruel, 2016-11-10 21:35:37]

lgtm, thanks all!

[M-A Ruel, 2016-11-10 21:35:44]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:36:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 21:43:23]

Description was changed from

==========
Roll src/tools/swarming_client/ 380e32662..ebc8dab6f (25 commits).

https://chromium.googlesource.com/external/swarming.client.git/+log/380e32662...

$ git log 380e32662..ebc8dab6f --date=short --no-merges --format='%ad %ae %s'
2016-11-01 dnj Update LogDog client library to generate URLs.
2016-11-01 bpastene Roll infra_libs to 564aaf7480f24c90687df79d9cef910cc342a54d
2016-10-31 aludwin Don't recreate a directory if it already exists
2016-10-31 vadimsh Fix how --auth-disabled works, in particular on headless
bots.
2016-10-28 iannucci Fix secret-bytes-path flag to use dashes instead of
underscores.
2016-10-28 iannucci Add secret_bytes functionality to swarming.
2016-10-28 aludwin Add --output option to Swarming client and pass it through to
the bot
2016-10-27 aludwin Return specific files, not just those in $(ISOLATED_OUTDIR)
2016-10-27 maruel Update stale links to code.google.com.
2016-10-27 iannucci Fix auth_server_test.py
2016-10-26 nodir swarming: implement named caches
2016-10-26 nodir run_isolated: fix --leak-temp-dir
2016-10-26 aludwin Pass args in file from task_runner to run_isolated
2016-10-20 iannucci Alter bot code to use new LUCI_CONTEXT library.
2016-10-19 nodir run_isolated: rename cache to isolate_cache
2016-10-19 iannucci Add luci_context library.
2016-10-18 nodir LRUDict: add timestamps
2016-10-13 leilei Fix encode issue.
2016-10-12 nodir run_isolated: rename cache to isolate_cache
2016-10-12 smut Don't assume existence of dimensions when querying for Swarming
bots
2016-09-14 ryanmartens Adds LUCI context auth service access token.
2016-09-13 vadimsh Add --service-account option to 'trigger' and 'run'.
2016-09-12 ryanmartens Adds auth option `luci_context_json`.
2016-09-09 vadimsh Implement local HTTP server that serves task OAuth access
tokens.
2016-09-07 ryanmartens Refactors authentictors into separate file.

BUG=659291
R=maruel@chromium.org,dnj@chromium.org
==========

to

==========
Roll src/tools/swarming_client/ 380e32662..ebc8dab6f (25 commits).

https://chromium.googlesource.com/external/swarming.client.git/+log/380e32662...

$ git log 380e32662..ebc8dab6f --date=short --no-merges --format='%ad %ae %s'
2016-11-01 dnj Update LogDog client library to generate URLs.
2016-11-01 bpastene Roll infra_libs to 564aaf7480f24c90687df79d9cef910cc342a54d
2016-10-31 aludwin Don't recreate a directory if it already exists
2016-10-31 vadimsh Fix how --auth-disabled works, in particular on headless
bots.
2016-10-28 iannucci Fix secret-bytes-path flag to use dashes instead of
underscores.
2016-10-28 iannucci Add secret_bytes functionality to swarming.
2016-10-28 aludwin Add --output option to Swarming client and pass it through to
the bot
2016-10-27 aludwin Return specific files, not just those in $(ISOLATED_OUTDIR)
2016-10-27 maruel Update stale links to code.google.com.
2016-10-27 iannucci Fix auth_server_test.py
2016-10-26 nodir swarming: implement named caches
2016-10-26 nodir run_isolated: fix --leak-temp-dir
2016-10-26 aludwin Pass args in file from task_runner to run_isolated
2016-10-20 iannucci Alter bot code to use new LUCI_CONTEXT library.
2016-10-19 nodir run_isolated: rename cache to isolate_cache
2016-10-19 iannucci Add luci_context library.
2016-10-18 nodir LRUDict: add timestamps
2016-10-13 leilei Fix encode issue.
2016-10-12 nodir run_isolated: rename cache to isolate_cache
2016-10-12 smut Don't assume existence of dimensions when querying for Swarming
bots
2016-09-14 ryanmartens Adds LUCI context auth service access token.
2016-09-13 vadimsh Add --service-account option to 'trigger' and 'run'.
2016-09-12 ryanmartens Adds auth option `luci_context_json`.
2016-09-09 vadimsh Implement local HTTP server that serves task OAuth access
tokens.
2016-09-07 ryanmartens Refactors authentictors into separate file.

BUG=659291
R=maruel@chromium.org,dnj@chromium.org
==========

[commit-bot: I haz the power, 2016-11-10 21:43:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-10 22:34:41]

Description was changed from

==========
Roll src/tools/swarming_client/ 380e32662..ebc8dab6f (25 commits).

https://chromium.googlesource.com/external/swarming.client.git/+log/380e32662...

$ git log 380e32662..ebc8dab6f --date=short --no-merges --format='%ad %ae %s'
2016-11-01 dnj Update LogDog client library to generate URLs.
2016-11-01 bpastene Roll infra_libs to 564aaf7480f24c90687df79d9cef910cc342a54d
2016-10-31 aludwin Don't recreate a directory if it already exists
2016-10-31 vadimsh Fix how --auth-disabled works, in particular on headless
bots.
2016-10-28 iannucci Fix secret-bytes-path flag to use dashes instead of
underscores.
2016-10-28 iannucci Add secret_bytes functionality to swarming.
2016-10-28 aludwin Add --output option to Swarming client and pass it through to
the bot
2016-10-27 aludwin Return specific files, not just those in $(ISOLATED_OUTDIR)
2016-10-27 maruel Update stale links to code.google.com.
2016-10-27 iannucci Fix auth_server_test.py
2016-10-26 nodir swarming: implement named caches
2016-10-26 nodir run_isolated: fix --leak-temp-dir
2016-10-26 aludwin Pass args in file from task_runner to run_isolated
2016-10-20 iannucci Alter bot code to use new LUCI_CONTEXT library.
2016-10-19 nodir run_isolated: rename cache to isolate_cache
2016-10-19 iannucci Add luci_context library.
2016-10-18 nodir LRUDict: add timestamps
2016-10-13 leilei Fix encode issue.
2016-10-12 nodir run_isolated: rename cache to isolate_cache
2016-10-12 smut Don't assume existence of dimensions when querying for Swarming
bots
2016-09-14 ryanmartens Adds LUCI context auth service access token.
2016-09-13 vadimsh Add --service-account option to 'trigger' and 'run'.
2016-09-12 ryanmartens Adds auth option `luci_context_json`.
2016-09-09 vadimsh Implement local HTTP server that serves task OAuth access
tokens.
2016-09-07 ryanmartens Refactors authentictors into separate file.

BUG=659291
R=maruel@chromium.org,dnj@chromium.org
==========

to

==========
Roll src/tools/swarming_client/ 380e32662..ebc8dab6f (25 commits).

https://chromium.googlesource.com/external/swarming.client.git/+log/380e32662...

$ git log 380e32662..ebc8dab6f --date=short --no-merges --format='%ad %ae %s'
2016-11-01 dnj Update LogDog client library to generate URLs.
2016-11-01 bpastene Roll infra_libs to 564aaf7480f24c90687df79d9cef910cc342a54d
2016-10-31 aludwin Don't recreate a directory if it already exists
2016-10-31 vadimsh Fix how --auth-disabled works, in particular on headless
bots.
2016-10-28 iannucci Fix secret-bytes-path flag to use dashes instead of
underscores.
2016-10-28 iannucci Add secret_bytes functionality to swarming.
2016-10-28 aludwin Add --output option to Swarming client and pass it through to
the bot
2016-10-27 aludwin Return specific files, not just those in $(ISOLATED_OUTDIR)
2016-10-27 maruel Update stale links to code.google.com.
2016-10-27 iannucci Fix auth_server_test.py
2016-10-26 nodir swarming: implement named caches
2016-10-26 nodir run_isolated: fix --leak-temp-dir
2016-10-26 aludwin Pass args in file from task_runner to run_isolated
2016-10-20 iannucci Alter bot code to use new LUCI_CONTEXT library.
2016-10-19 nodir run_isolated: rename cache to isolate_cache
2016-10-19 iannucci Add luci_context library.
2016-10-18 nodir LRUDict: add timestamps
2016-10-13 leilei Fix encode issue.
2016-10-12 nodir run_isolated: rename cache to isolate_cache
2016-10-12 smut Don't assume existence of dimensions when querying for Swarming
bots
2016-09-14 ryanmartens Adds LUCI context auth service access token.
2016-09-13 vadimsh Add --service-account option to 'trigger' and 'run'.
2016-09-12 ryanmartens Adds auth option `luci_context_json`.
2016-09-09 vadimsh Implement local HTTP server that serves task OAuth access
tokens.
2016-09-07 ryanmartens Refactors authentictors into separate file.

BUG=659291
R=maruel@chromium.org,dnj@chromium.org

Committed: https://crrev.com/bc0614e467b9538c2930b93a5c058c8b66c93cac
Cr-Commit-Position: refs/heads/master@{#431365}
==========

[commit-bot: I haz the power, 2016-11-10 22:34:43]

Patchset 3 (id:??) landed as
https://crrev.com/bc0614e467b9538c2930b93a5c058c8b66c93cac
Cr-Commit-Position: refs/heads/master@{#431365}