[Offline Pages] Clear remaining requests after test harness finishes.

chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.offlinepages;
 
 import android.app.NotificationManager;
 import android.content.Context;
 import android.os.Environment;
 import android.text.TextUtils;
@@ skipping 64 matching lines @@
     private static final String TAG = "OPSPLEvaluation";
     private static final String NAMESPACE = "async_loading";
     private static final String NEW_LINE = System.getProperty("line.separator");
     private static final String DELIMITER = ";";
     private static final String CONFIG_FILE_PATH = "paquete/test_config";
     private static final String INPUT_FILE_PATH = "paquete/offline_eval_urls.txt";
     private static final String LOG_OUTPUT_FILE_PATH = "paquete/offline_eval_logs.txt";
     private static final String RESULT_OUTPUT_FILE_PATH = "paquete/offline_eval_results.txt";
     private static final int GET_PAGES_TIMEOUT_MS = 5000;
     private static final int PAGE_MODEL_LOAD_TIMEOUT_MS = 5000;
+    private static final int REMOVE_REQUESTS_TIMEOUT_MS = 5000;

[Pete Williamson, 2016/11/07 23:45:26]

Maybe allow a longer timeout.  A svelte device might be busy, and we don't
really want to fail the test if the timeout happens (or stop trying to clean
up).  30s might be a better timeout than 5s.

[romax, 2016/11/08 00:18:35]

Done.
I've also updated the timeouts above.

 
     private OfflinePageEvaluationBridge mBridge;
     private OfflinePageEvaluationObserver mObserver;
 
     private Semaphore mDoneSemaphore;
     private List<String> mUrls;
     private int mCount;
     private boolean mIsUserRequested;
     private boolean mUseTestScheduler;
 
     private LongSparseArray<RequestMetadata> mRequestMetadata;
     // TODO(romax): Use actual policy to determine the timeout.
     private Long mTimeoutPerUrlInSeconds = 0L;
     private OutputStreamWriter mLogOutput;
 
     public OfflinePageSavePageLaterEvaluationTest() {
         super(ChromeActivity.class);
     }
 
     @Override
     protected void setUp() throws Exception {
         super.setUp();
         mRequestMetadata = new LongSparseArray<RequestMetadata>();
         mCount = 0;
     }
 
     @Override
     protected void tearDown() throws Exception {
-        super.tearDown();
         NotificationManager notificationManager =
                 (NotificationManager) ContextUtils.getApplicationContext().getSystemService(
                         Context.NOTIFICATION_SERVICE);
         notificationManager.cancelAll();
+        final Semaphore mClearingSemaphore = new Semaphore(0);

[Pete Williamson, 2016/11/07 23:45:26]

I see where we decrement the count and release the semaphore, where do we
increment the count?

[romax, 2016/11/08 00:18:35]

This is used as a way to block the thread until timeout or the callback has been
called. So seems there's no need to increment the count. I might be wrong here
but this is how I understand this usage...

[Pete Williamson, 2016/11/08 00:51:35]

Ah, so it is only called once, not once per request.

+        ThreadUtils.runOnUiThread(new Runnable() {
+            @Override
+            public void run() {
+                mBridge.getRequestsInQueue(new Callback<SavePageRequest[]>() {
+                    @Override
+                    public void onResult(SavePageRequest[] results) {
+                        ArrayList<Long> ids = new ArrayList<Long>(results.length);
+                        for (int i = 0; i < results.length; i++) {
+                            ids.add(results[i].getRequestId());
+                        }
+                        mBridge.removeRequestsFromQueue(ids, new Callback<Integer>() {
+                            @Override
+                            public void onResult(Integer removedCount) {
+                                mClearingSemaphore.release();
+                            }
+                        });
+                    }
+                });
+            }
+        });
+        checkTrue(mClearingSemaphore.tryAcquire(REMOVE_REQUESTS_TIMEOUT_MS, TimeUnit.MILLISECONDS),
+                "Timed out when clearing remaining requests!");
+        super.tearDown();
     }
 
     @Override
     public void startMainActivity() throws InterruptedException {
         startMainActivityOnBlankPage();
     }
 
     /**
      * Get a reader for a given input file path.
      */
@@ skipping 314 matching lines @@
      * The test is the entry point for all kinds of testing of SavePageLater.
      * It is encouraged to use run_offline_page_evaluation_test.py to run this test.
      */
     @Manual
     public void testFailureRateWithTimeout() throws IOException, InterruptedException {
         parseConfigFile();
         setUpIOAndBridge(mUseTestScheduler);
         processUrls(mUrls);
     }
 }