third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js - Issue 2482593003: DevTools: eliminate ToolbarButton.setState method; cleanup toolbar.css

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

Issue 2482593003: DevTools: eliminate ToolbarButton.setState method; cleanup toolbar.css (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js b/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

index 67617709249b2a6cb1e64f3c50a3a793acd1adef..7f5c1e5dc3cbdce495e8139818edfe44c7243587 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

@@ -833,7 +833,7 @@ WebInspector.SplitWidget = class extends WebInspector.Widget {

createShowHideSidebarButton(title) {

this._showHideSidebarButtonTitle = WebInspector.UIString(title);

- this._showHideSidebarButton = new WebInspector.ToolbarButton('', 'sidebar-toolbar-item');

+ this._showHideSidebarButton = new WebInspector.ToolbarButton('', '');

this._showHideSidebarButton.addEventListener('click', buttonClicked.bind(this));

this._updateShowHideSidebarButton();

@@ -857,7 +857,7 @@ WebInspector.SplitWidget = class extends WebInspector.Widget {

var sidebarHidden = this._showMode === WebInspector.SplitWidget.ShowMode.OnlyMain;

var side =

this.isVertical() ? (this.isSidebarSecond() ? 'right' : 'left') : (this.isSidebarSecond() ? 'bottom' : 'top');

- this._showHideSidebarButton.setState(side + '-' + (sidebarHidden ? 'show' : 'hide'));

+ this._showHideSidebarButton.setGlyph((sidebarHidden ? 'show-' : 'hide-') + side + '-sidebar-item');

this._showHideSidebarButton.setTitle(

sidebarHidden ? WebInspector.UIString('Show %s', this._showHideSidebarButtonTitle) :

WebInspector.UIString('Hide %s', this._showHideSidebarButtonTitle));