Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2482583002: Ensure ShellExtensionSystem::Init() is called in all extensions_browsertests. (Closed)

Created:
4 years, 1 month ago by jam
Modified:
4 years, 1 month ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure ShellExtensionSystem::Init() is called in all extensions_browsertests. This manifested in hangs in a test with PlzNavigate after r429936 now that NavigationUIData was being set. This correctly led to the WebRequest API code (ExtensionWebRequestEventRouter::ProcessDeclarativeRules) classifying a request as a webview one, and waiting for rules_registry->ready() to signal. That's signalled through ShellExtensionSystem::Init. This fixes WebViewAPITest.TestNewWindow with PlzNavigate. BUG=661812 Committed: https://crrev.com/d2a5e683bf6562bd0eb86c2c8281a025a1aee5f0 Cr-Commit-Position: refs/heads/master@{#430075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M extensions/browser/guest_view/app_view/app_view_apitest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/shell/test/shell_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jam
4 years, 1 month ago (2016-11-04 23:23:39 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-11-04 23:26:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482583002/1
4 years, 1 month ago (2016-11-04 23:28:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 00:16:40 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 00:19:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2a5e683bf6562bd0eb86c2c8281a025a1aee5f0
Cr-Commit-Position: refs/heads/master@{#430075}

Powered by Google App Engine
This is Rietveld 408576698