Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2482573002: fix #27764, split STATIC_TYPE_ERROR into more detailed ones (Closed)

Created:
4 years, 1 month ago by Jennifer Messerly
Modified:
4 years, 1 month ago
Reviewers:
Leaf
CC:
reviews_dartlang.org, pquitslund, srawlins
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27764, split STATIC_TYPE_ERROR into more detailed ones R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/68f290c9d84da8bef8381452d2a9f42a0a646234

Patch Set 1 #

Patch Set 2 : tweak message #

Patch Set 3 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -70 lines) Patch
M pkg/analyzer/lib/error/error.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 1 2 chunks +47 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 2 2 chunks +25 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 17 chunks +48 lines, -48 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
4 years, 1 month ago (2016-11-04 23:28:56 UTC) #2
Leaf
lgtm We need to coordinate with Phil and Sam to be sure that any flutter ...
4 years, 1 month ago (2016-11-05 00:00:17 UTC) #3
Jennifer Messerly
Sounds great! Phil, Sam, let me know if I can help.
4 years, 1 month ago (2016-11-05 00:02:40 UTC) #4
Jennifer Messerly
4 years, 1 month ago (2016-11-05 00:04:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
68f290c9d84da8bef8381452d2a9f42a0a646234 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698