Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2482553002: [MD Settings][People] UI polish for the easy unlock row (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index 2fd9a5dbb2efda232db21bf4e0a18fe6185f081e..d116f5b0dc956d77c8860079eac93cdc790f15ed 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -63,6 +63,10 @@
color: var(--settings-error-color);
}
+ .settings-box.three-line {
+ min-height: 100px;
+ }
+
.icon-container {
display: flex;
flex-shrink: 0;
@@ -205,8 +209,9 @@
</template>
<template is="dom-if" if="[[easyUnlockAllowed_]]">
- <div class="settings-box">
- <div class="middle">
+ <div class$="settings-box [[getEasyUnlockClass_(
+ easyUnlockEnabled_, easyUnlockProximityDetectionAllowed_)]]">
stevenjb 2016/11/04 22:52:08 This is kind of awkward. We definitely shouldn't b
Moe 2016/11/06 21:43:14 Done.
+ <div class="start">
<div>$i18n{easyUnlockSectionTitle}</div>
<div class="secondary">
<template is="dom-if" if="[[!easyUnlockEnabled_]]">
@@ -215,7 +220,7 @@
<template is="dom-if" if="[[easyUnlockEnabled_]]">
$i18n{easyUnlockDescription}
</template>
- <a target="_blank" href$="$i18n{easyUnlockLearnMoreURL}">
+ <a target="_blank" href="$i18n{easyUnlockLearnMoreURL}">
$i18n{learnMore}
</a>
<template is="dom-if" if="[[easyUnlockEnabled_]]">
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698